Skip to content

Feature/r2 images links #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kargig merged 25 commits into from
Jan 1, 2026
Merged

Feature/r2 images links #139

kargig merged 25 commits into from
Jan 1, 2026

Conversation

@Johnbin89
Copy link
Contributor

@Johnbin89 Johnbin89 commented Jan 1, 2026 •
edited by kargig
Loading

R2 Photo Upload Functionality

  • Added methods to R2 storage service for photo uploads to Cloudflare R2
  • Created reusable UploadPhotosComponent with drag-and-drop support using Ant Design Dragger
  • Integrated photo upload in Create/Edit Dive and Create/Edit Dive Site pages
  • Photos are uploaded to R2 on form submission, with local base64 previews during editing
  • Added endpoints for R2-only photo uploads for dives and dive sites
  • Updated dive media endpoints to generate presigned URLs for R2 paths

Media Management Enhancements

  • Added "Manage Media" collapsible sections for existing media in Edit Dive and Edit Dive Site
  • Added "Add External Links" collapsible sections for adding photo/video URLs
  • External links support both direct URLs and Flickr URLs (with automatic conversion)
  • Media descriptions are editable inline in the Manage Media section
  • Pending media are displayed (yellow border) before saving
  • Flickr URL conversion helper to get flickr static image link from Flickr share URL/User photo URL

Media Display Improvements

  • Added Lightbox(Gallery) component for photo viewing with navigation
  • Photos and videos are on different Tabs

Permission & Authorization Fixes

  • Fixed dive site edit permissions to allow owners (in addition to admins/moderators)

UI/UX Improvements

  • Refactored OrganizationCard to use Ant Design Drawer component for certification levels
  • Drawer opens on card click or via "View certifications" button
  • Fixed boolean field conversion issues on dive_site Edit (is_private select field)

Implements: #55

Johnbin89 and others added 25 commits December 29, 2025 13:20
@Johnbin89
initial photo upload | description | Lightbox | Flickr share URLs at …
07e622e 
…media URL
@Johnbin89
Merge branch 'main' into 55-r2-dive-site-images
357e5cd
@Johnbin89
resolve conflicts
3593f17
@Johnbin89
resolve conflict | npm install antd
623d86b
@Johnbin89
update package-lock.json
5cbba42
@Johnbin89
Certification on Drawer component | DivingOrganizationsPage
cfdf8f4
@Johnbin89
Edit Dive Upload component | Initial working example
825f364
@Johnbin89
Create Custom Component | Upload photos to R2. TODO: use it on Create…
d07dbeb 
…Dive | Edit works
@Johnbin89
rename upload component | UploadPhotosComponent
2d9f287
@Johnbin89
rename upload component class | propTypes
7b08435
@Johnbin89
rename upload component propTypes
6f093a2
@Johnbin89
external links / photos /video only
b795a12
@Johnbin89
photos public only | CreateDive | EditDive
33c5958
@Johnbin89
fix dive site Owner | Edit Dive permission
7e42ffd
@Johnbin89
backend deny edit dive site if current user not owner
513eb9e
@Johnbin89
EditDiveSite | Add - Upload media | Manage Media
c2271b2
@Johnbin89
CreateDive | EditDive | Manage Media - update delete
f13b4dc
@Johnbin89
EditDiveSite | Manage Media -for existing photos | use External flick…
4eefeb4 
…r helper
@Johnbin89
CreateDiveSite add: Upload component | External Link Component
8beb1f9
@Johnbin89
Merge branch 'main' into feature/R2-images-links
6dca68e
@Johnbin89
prettier lint format
2d86c18
@Johnbin89
remove always null ID Upload component | lint:ci fixes
d16d0d2
@kargig
Merge branch 'upstream/main' into PR 139 and fix dependencies
e420fc1
@kargig
Fix frontend dependencies and linting configuration
b0703c7 
- Install missing `antd` and `@ant-design/icons` dependencies.
- Install `eslint-import-resolver-exports` to properly resolve subpath exports.
- Update ESLint configuration to use the exports resolver, fixing import errors for `yet-another-react-lightbox`.
@kargig
Add backend tests for R2 image and link handling
61fe794 
- Create `backend/tests/test_r2_images_links.py` to cover:
  - `get_photo_url` logic for local, R2 presigned, and R2 public URLs.
  - `upload_photo` logic including R2 upload and local fallback.
  - `delete_photo` logic for both R2 and local storage.
- Ensure comprehensive test coverage for new R2 storage service features.
@kargig kargig merged commit 10ceefc into kargig:main Jan 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Johnbin89 @kargig