Skip to content

fix(helpers): condition to check if we reached the end of the carousel for translateX#102

Open
YassineHaouzane wants to merge 1 commit intokareemaly:masterfrom
YassineHaouzane:fix/chevron-displaying-at-end
Open

fix(helpers): condition to check if we reached the end of the carousel for translateX#102
YassineHaouzane wants to merge 1 commit intokareemaly:masterfrom
YassineHaouzane:fix/chevron-displaying-at-end

Conversation

@YassineHaouzane
Copy link

This PR fixes the following bug :

Animation
As you can see the right arrow is still displayed when we reach the end of the carousel.

You can reproduce this bug with this configuration:

{
  "noOfChildren": 4,
  "wrapperStyle": {
    "padding": "0 60px",
    "maxWidth": 763,
    "margin": "0 auto"
  },
  "componentProps": {
    "infiniteLoop": false,
    "activePosition": "left",
    "numberOfCards": 1.8,
    "slidesToScroll": 1.8
  }
}

@noumankhandatu
Copy link

Its not working with typescript

@noumankhandatu
Copy link

Could not find a declaration file for module 'react-items-carousel'. 'c:/Projects/Leximind/leximid-dashboard/node_modules/react-items-carousel/dist/react-items-carousel.js' implicitly has an 'any' type.
Try npm i --save-dev @types/react-items-carousel if it exists or add a new declaration (.d.ts) file containing declare module 'react-items-carousel';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants