-
-
Notifications
You must be signed in to change notification settings - Fork 85
Support for bevy 0.15 #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: blenvy
Are you sure you want to change the base?
Conversation
spacekookie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR fixes the build issues in my game with bevy 0.15 and the blenvy plugin. There are however some compilation issues in the examples (that might be unrelated?) I don't understand
9dbfb40 to
3fd2784
Compare
|
Apologies forgot I'd done this and left it in draft. |
The examples seem to compile for me, there are some issues related to asset loading if you try and run them outside of their directory. i.e. vs: Looks like this is fixed by #256 🤷♀️ |
81f099b to
998990e
Compare
|
I hate to beg for merge requests, but could we get a review/ approval? @spacekookie @kaosat-dev Thanks! |
|
Theres a few issues with the Blender plugin on this branch that I ran into while using it myself.
Both of these commits are free for cherry-picking/copying. |
|
Btw @ptsd , would you be ok with rebasing this PR if I merge the other smaller PRs that preceded it ? |
No problem at all :) |
|
any timeline on when this can get merged? |
|
Is there anything blocking for this? |
@CoryRobertson Waiting for the probably very busy maintainer ❤️ For now you can use cargos git dependency or patch features to use this branch overriding-dependencies. I.e. either: [dependencies]
blenvy = { git = "https://github.com/ptsd/Blenvy.git", branch = "blenvy-bevy-0.15" }or [dependencies]
blenvy = "0.1.0-alpha.2"
[patch.crates-io]
blenvy = { git = "https://github.com/ptsd/Blenvy.git", branch = "blenvy-bevy-0.15" }This has the usual warning of being careful trusting peoples forks as what is there now can change in the future. You can hard lock to a revision (see the docs above, and be warned this is still not 100% safe) or you can fork that branch yourself and review the changes before adding if thats important for you 🤷 |
Thanks 🙏, I currently have this set up for a few other things I suppose I'll do that for this as well, I also have my own fork and just tried winging it to make it work for bevy .16 but it seems that breaking changed came to a few components that make it not happy. Regardless I appreciate you! Thanks! |
No description provided.