🐛 Fix poll error on Niri in tablet mode #1247
Open
+257
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 Fix poll error on Niri in tablet mode
…5s for tablet mode)
Schneegans
requested changes
Jan 16, 2026
Contributor
Schneegans
left a comment
Schneegans
left a comment
There was a problem hiding this comment.
Thanks again! This looks good already! I just added a few suggestions below.
|
|
||
| /** | ||
| * How long the WLRoots backend will wait before spawning the menu if it can't find the | ||
| * the pointer and you're using a mouse |
Contributor
There was a problem hiding this comment.
Suggested change
| * the pointer and you're using a mouse | |
| * the pointer and you're using touch input |
Comment on lines
+65
to
+68
| // Set timeout options | ||
| this.mouseTimeout = generalSettings.get('wlrootsPointerGetTimeoutMouse'); | ||
| this.touchTimeout = generalSettings.get('wlrootsPointerGetTimeoutTouch'); | ||
| this.defaultBehavior = generalSettings.get('wlrootsPointerGetTimeoutDefaultBehavior'); |
Contributor
There was a problem hiding this comment.
Is there a reason why you put this initialization into the NiriBackend but use the values in the base class? This is a bit weird, I think.
Getting those values is very fast. I would suggest to just keep a reference to the general settings in the wlroots backend and read the values when needed. Then there's also no need to re-initialize the backend.
Comment on lines
+36
to
+37
| public mouseTimeout: number = 0; | ||
| public touchTimeout: number = 0; |
Contributor
There was a problem hiding this comment.
As mentioned above, those are not really needed.
Suggested change
| public mouseTimeout: number = 0; | |
| public touchTimeout: number = 0; |
Comment on lines
+91
to
+94
| const data = native.getPointerPositionAndWorkAreaSize( | ||
| this.mouseTimeout, | ||
| this.touchTimeout | ||
| ); |
Contributor
There was a problem hiding this comment.
Here I would read the settings before. Something like this:
Suggested change
| const data = native.getPointerPositionAndWorkAreaSize( | |
| this.mouseTimeout, | |
| this.touchTimeout | |
| ); | |
| const data = native.getPointerPositionAndWorkAreaSize( | |
| this.generalSettings.get('wlrootsPointerGetTimeoutMouse'), | |
| this.generalSettings.get('wlrootsPointerGetTimeoutTouch') | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix poll error on Niri in tablet mode.
Should address #1246 by checking for capabilities and only hooking a pointer handler when there is a pointer.
Also adds a touch handler (note, events are only received if the touchscreen is pressed, so if no touches are detected within the timeout period of 500ms, the default position will be used)