-
-
Notifications
You must be signed in to change notification settings - Fork 154
Added repeat last action functionality! #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi there! Thanks again for the initiative. Yet I think this should be tackled with #528 in mind. Here, the idea is to assign the center action on a per-submenu basis. So each submenu (including the root menu) should get a drop-down option "Center Action" with the following options:
Currently, when you hover over the center of a submenu, the parent link is highlighted. With this new option, you can change this. If you select one of the children as the center action, this child will be highlighted instead. So you can create some sort of quick-action path through the menu where you only need to click the center items to got to a specific submenu. Repeat-last is then just another option in this dropdown. Yet one question needs to be answered. Which previous action is to be executed?
Maybe it would be great if all these three were options in the center-action dropdown! |
Thanks for review! Good point on drop-down option! I will try to implement this feature as you suggested |
|
I will continue work on this tomorow |
|
@Schneegans Im ready for review... |
|
Any updates on this? |
|
I haven't looked into the code yet. I played around a bit and seems promising! One feature which is definitely missing is that the correct center-action child is highlighted. So if the pointer is over the center of a submenu, currently the parent is highlighted. This should only be the case if the center-action is set to go-to-parent. Else, the selected child should be highlighted. Also, I was just thinking about this: What if we introduced a new menu item type: Repeat Last. This new menu item type would have the option to choose between last-global, last-from-menu and last-from-submenu. Then, if you want to have this functionality for the center, you could add such an item to your menu and choose this in the center-action dropdown. Maybe this would make things a bit more flexible? Then people would have the choice to put the repeat-last functionality into a menu item or the center... Also, it would make the center-action functionality cleaner from a mental-model point of view: Currently, you choose between child item selections and some additional, random options. With this change, you would always select one of the items when you click the center. This is much easier to conceptualize, I think! What do you think? |
You can enable this in menu settings, closes #1039 issue