Open
Conversation
use genre filter
Reviewer's Guide by SourceryThis pull request introduces a new HTML file, Sequence diagram for genre filtering interactionsequenceDiagram
actor User
participant Filter as Genre Filter
participant Sections as Category Sections
participant Display as Book Display
User->>Filter: Select genre
Filter->>Sections: Get all sections
loop Each section
Filter->>Sections: Check category
alt Selected genre matches or 'all'
Sections->>Display: Show section
else No match
Sections->>Display: Hide section
end
end
Class diagram showing book management system structureclassDiagram
class Book {
+String title
+String genre
+String imageUrl
+Boolean isComplete
+openBook()
+markComplete()
}
class GenreFilter {
+String selectedGenre
+filterBooks()
+updateDisplay()
}
class CategorySection {
+String category
+Array~Book~ books
+display()
+hide()
}
GenreFilter --> CategorySection : filters
CategorySection --> Book : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for vrkpzs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hey @ROHITKUMARMODI - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider moving inline styles to the CSS file to improve maintainability and follow separation of concerns principles
- The book listings contain significant repetition - consider using a data file/database and templating to generate the HTML dynamically rather than hardcoding all entries
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use genre filter main role by Pravesh Arya of js function, css and direction of showing the things done by Rohit and Kallal
Summary by Sourcery
New Features: