Open
Conversation
update in search button and hover part of main file it show read book in place of click to read
Reviewer's Guide by SourceryThis PR introduces a new HTML file named No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for vrkpzs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hey @ROHITKUMARMODI - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's an inconsistency in the button text - one instance shows 'Ride Book' instead of 'Read Book'. Please ensure consistent button text across all book items.
- Consider refactoring the repetitive category sections using templates or components to improve code maintainability and reduce duplication.
- The commit message and PR description should be more descriptive and clearly explain the changes being made. Please follow proper commit message conventions.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| </div> | ||
| <div class="book-overlay"> | ||
| <button class="complete-btn">Complete</button> | ||
| <button class="click-btn"> Ride Book</button> |
There was a problem hiding this comment.
issue (typo): Button text should be 'Read Book' instead of 'Ride Book' for consistency
Suggested change
| <button class="click-btn"> Ride Book</button> | |
| <button class="click-btn">Read Book</button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update in search button and hover part of main file it show read book in place of click to read use some hover changes by me
Summary by Sourcery
New Features: