Switch to cmake-suggested install path variables#36
Switch to cmake-suggested install path variables#36merkys wants to merge 27 commits intokakwa:masterfrom
Conversation
Replace the static definition of the past with a more dynamic setup * use libfontconfig to find the ttf file of the font * use libfreetype to generate the reverse cmap * change a few internal API to take into account weight and italic * use the new dynamic setup in the fontindex_to_utf8 function
* add support of EMRSETMITERLIMIT (handling of the record + set
stroke-miterlimit svg property when necessary)
* remove the systematic "Z" (close shape) when calling EMRENDPATH
* have a logic that ensure at least a 1px stroke-width
|
Hello, Thanks for the PR. However, I have two concerns regarding this change:
If this change really do make things easier/more compliant, would it be possible for you to rework it so that both This issue also has been discussed in the past in #22 |
Interesting. Maybe things have changed in cmake debian helper since then, as I had to do some minor tweaking. As for warnings, CMake reports unused variables from the command line, so I don't think this is of much importance.
Indeed, my PR as-is would break packaging for these distributions. I wasn't aware that these distributions did not honor
This could indeed be done. I will give it a look.
Thanks for the link. |
2 participants
I noticed the project uses
*_INSTALL_DIRvariables to control installation destinations. CMake recommends usingCMAKE_INSTALL_*DIRvariables, as "[T]his allows package maintainers to control the install destination by setting the appropriate cache variables." I am packaging libemf2svg for Debian, and havingCMAKE_INSTALL_*DIRvariables would be more convenient to do that.