Open
Conversation
Contributor
grogy
commented
Oct 9, 2016
grogy
commented
- update Composer is not necessary in CI server
- --dev is default configuration in Composer
- update Composer is not necessary in CI server - --dev is default configuration in Composer
fprochazka
suggested changes
Oct 10, 2016
| before_script: | ||
| - composer self-update | ||
| - composer install --no-interaction --prefer-source --dev | ||
| - composer install --no-interaction --prefer-source |
There was a problem hiding this comment.
actually it's better to always do composer update & cache ~/.composer like nette/di does it
Contributor
Author
There was a problem hiding this comment.
Thanks for feedback :-) What is the reason for it?
There was a problem hiding this comment.
It's faster :) composer has a local cache for all the files it downloads (you should also use --prefer-dist), and travis can cache that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.