-
Notifications
You must be signed in to change notification settings - Fork 35
Adding Path MMU Atlas to Eva #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e206f03 to
6662f55
Compare
0d15466 to
9a8f612
Compare
nkaenzig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left a couple of comments.
src/eva/multimodal/data/datasets/multiple_choice/path_mmu_atlas.py
Outdated
Show resolved
Hide resolved
configs/multimodal/pathology/online/multiple_choice/path_mmu_atlas.yaml
Outdated
Show resolved
Hide resolved
configs/multimodal/pathology/online/multiple_choice/path_mmu_atlas.yaml
Outdated
Show resolved
Hide resolved
configs/multimodal/pathology/online/multiple_choice/path_mmu_atlas.yaml
Outdated
Show resolved
Hide resolved
src/eva/multimodal/data/datasets/multiple_choice/path_mmu_atlas.py
Outdated
Show resolved
Hide resolved
jonaserb-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented all changes as requested per PR. I actually removed the whole download.py utilities file since I realised it is too extensive for the actual use case and just implemented everything directly in path_mmu_atlas.py. Also added docs etc.
configs/multimodal/pathology/online/multiple_choice/path_mmu_atlas.yaml
Outdated
Show resolved
Hide resolved
configs/multimodal/pathology/online/multiple_choice/path_mmu_atlas.yaml
Outdated
Show resolved
Hide resolved
configs/multimodal/pathology/online/multiple_choice/path_mmu_atlas.yaml
Outdated
Show resolved
Hide resolved
src/eva/multimodal/data/datasets/multiple_choice/path_mmu_atlas.py
Outdated
Show resolved
Hide resolved
src/eva/multimodal/data/datasets/multiple_choice/path_mmu_atlas.py
Outdated
Show resolved
Hide resolved
...modal/datasets/path_mmu_atlas/arch/books_set/images/16b3cf5e-2a8c-47df-afe1-71c557be22b5.png
Show resolved
Hide resolved
tests/eva/multimodal/data/datasets/multiple_choice/test_path_mmu_atlas.py
Show resolved
Hide resolved
src/eva/multimodal/data/datasets/multiple_choice/path_mmu_atlas.py
Outdated
Show resolved
Hide resolved
nkaenzig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work 🚀
…ad.py and implemented it directly in the path_mmu_atlas.py in a simplified form, added docs for path mmu atlas, added cli tests and some other minor changes
ed256f1 to
ea85466
Compare
…ROC is removed for micro averaging
97a2376 to
52ef809
Compare
Summary
This PR adds native support for the PathMMU Atlas dataset, a multimodal Visual Question Answering (VQA) benchmark for pathology. The implementation enables eva to directly load and evaluate models on expert-validated pathology questions derived from the ARCH Book Set.
Key changes:
PathMMUAtlasdataset class for multimodal VQA evaluationDataset Overview
PathMMU Atlas combines:
Licenses: CC-BY-ND-4.0 (PathMMU), CC-BY-NC-SA-4.0 (ARCH Book Set)
Files Added/Modified
New Files
src/eva/multimodal/data/datasets/multiple_choice/path_mmu_atlas.py- Main dataset implementationconfigs/multimodal/pathology/online/multiple_choice/path_mmu_atlas.yaml- Evaluation configtests/eva/multimodal/data/datasets/multiple_choice/test_path_mmu_atlas.py- Test suite (21 tests)tests/eva/assets/multimodal/datasets/path_mmu_atlas/- Test assets (sample images + data.json)Modified Files
src/eva/multimodal/data/datasets/__init__.py- Export PathMMUAtlassrc/eva/multimodal/data/datasets/multiple_choice/__init__.py- Export PathMMUAtlassrc/eva/core/metrics/defaults/classification/multiclass.py- Minor fixsrc/eva/vision/data/datasets/classification/__init__.py- Remove duplicate Camelyon16 entryTesting
Usage