Skip to content

fix build issue #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmedfayed29 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix build issue #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b770c3
fix: update compileSdkVersion to 36
ahmedfayed29 Dec 9, 2025
dfa449e
fix: update compileSdkVersion to 36
ahmedfayed29 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ apply plugin: 'com.android.library'

android {
namespace "dev.kaichi.easy_pdf_viewer"
compileSdkVersion 34
compileSdkVersion 36
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compileSdkVersion was bumped to 36 while this module still uses Android Gradle Plugin 7.0.0 (see buildscript dependencies). AGP 7.0.x is not compatible with such a high compileSdkVersion and this is likely to introduce/retain build failures for consumers. Please either keep compileSdkVersion at a level supported by AGP 7.0.x, or upgrade the Android toolchain together (AGP + Gradle wrapper + related settings) and document the required SDK/AGP versions.

Suggested change
compileSdkVersion 36
compileSdkVersion 31

Copilot uses AI. Check for mistakes.

defaultConfig {
minSdkVersion 16
Expand Down
4 changes: 2 additions & 2 deletions example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 34
compileSdkVersion 36

defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "dev.kaichi.easy_pdf_viewer_example"
targetSdkVersion 34
targetSdkVersion 36
minSdkVersion 23
multiDexEnabled true
versionCode flutterVersionCode.toInteger()
Expand Down