Skip to content

Fix/normalize digits #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NavidHosseini wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/normalize digits #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a42a03d
Update pubspec.yaml
NavidHosseini Aug 23, 2025
dd5550d
Fix: normalize non-English digits before int.parse
NavidHosseini Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions lib/src/document.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class PDFDocument {
try {
var pageCount = await _channel.invokeMethod('getNumberOfPages',
{'filePath': file.path, 'clearCacheDir': clearPreviewCache});
document.count = document.count = int.parse(pageCount);
document.count = document.count = _safeParseInt(pageCount);
} catch (e) {
throw Exception('Error reading PDF!');
}
Expand Down Expand Up @@ -62,7 +62,7 @@ class PDFDocument {
try {
var pageCount = await _channel.invokeMethod('getNumberOfPages',
{'filePath': f.path, 'clearCacheDir': clearPreviewCache});
document.count = document.count = int.parse(pageCount);
document.count = document.count = _safeParseInt(pageCount);
} catch (e) {
throw Exception('Error reading PDF!');
}
Expand Down Expand Up @@ -141,7 +141,7 @@ class PDFDocument {
try {
var pageCount = await _channel.invokeMethod('getNumberOfPages',
{'filePath': file.path, 'clearCacheDir': clearPreviewCache});
document.count = document.count = int.parse(pageCount);
document.count = document.count = _safeParseInt(pageCount);
} catch (e) {
throw Exception('Error reading PDF!');
}
Expand Down Expand Up @@ -221,4 +221,15 @@ class PDFDocument {
);
}).asStream() as Stream<PDFPage?>;
}
static int _safeParseInt(String input) {
const easternArabic = ['٠', '١', '٢', '٣', '٤', '٥', '٦', '٧', '٨', '٩'];
const persian = ['۰', '۱', '۲', '۳', '۴', '۵', '۶', '۷', '۸', '۹'];
const western = ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9'];

for (int i = 0; i < 10; i++) {
input = input.replaceAll(easternArabic[i], western[i]);
input = input.replaceAll(persian[i], western[i]);
}
return int.parse(input);
}
}
3 changes: 2 additions & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ version: 1.0.8
homepage: https://github.com/kaichii/pdf_viewer

environment:
sdk: '>=3.3.1 <4.0.0'
sdk: '>=2.12.0 <4.0.0'
flutter: '>=1.20.0'

dependencies:
flutter:
Expand Down