Skip to content

fix(rbac): Add missing agentruntimes permissions to ClusterRole #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alan-Cha wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −0
Open

fix(rbac): Add missing agentruntimes permissions to ClusterRole #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions charts/kagenti-operator/templates/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,32 @@ rules:
- get
- patch
- update
- apiGroups:
- agent.kagenti.dev
resources:
- agentruntimes
verbs:
- create
- delete
- get
Copy link
Copy Markdown
Collaborator

@cwiklik cwiklik Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (coordination): This exact change is also included in PR #249, which does a broader RBAC cleanup aligning the entire Helm ClusterRole with config/rbac/role.yaml. PR #249 adds agentruntimes (same rules as here) plus removes ~79 lines of over-provisioned permissions the operator doesn't use (secrets, CRDs, webhooks, RBAC, deprecated extensions API group, etc.).

These two PRs will conflict on this file. If #249 merges first, this PR is fully superseded. Worth coordinating merge order with @ChristianZaccaria.

Copy link
Copy Markdown
Contributor Author

@Alan-Cha Alan-Cha Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it makes sense to merge #249 as the changes are more extensive. We can close this after that one is merged.

- list
- patch
- update
- watch
- apiGroups:
- agent.kagenti.dev
resources:
- agentruntimes/finalizers
verbs:
- update
- apiGroups:
- agent.kagenti.dev
resources:
- agentruntimes/status
verbs:
- get
- patch
- update
- apiGroups:
- networking.k8s.io
resources:
Expand Down
Loading