Skip to content

🐛 Align configMapKey default to bundle.spiffe across Helm and make deploy #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristianZaccaria wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Align configMapKey default to bundle.spiffe across Helm and make deploy #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions charts/kagenti-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,12 @@ signatureVerification:
enforceNetworkPolicies: false
# SPIRE trust domain (required when enabled)
spireTrustDomain: ""
# SPIRE trust bundle ConfigMap (PEM from ZTWIM/SPIRE or SPIFFE JSON from BundlePublisher)
# Key within the SPIRE trust bundle ConfigMap. Matches the SPIRE hardened Helm chart default
# and the binary flag default. Override to "bundle.crt" only for older ZTWIM deployments.
spireTrustBundle:
Copy link
Copy Markdown
Collaborator

@cwiklik cwiklik Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch — silent divergence between Helm and make deploy defaults is exactly the kind of subtle bug that causes hard-to-debug behavior. Verified: Go binary at cmd/main.go defaults to "bundle.spiffe". The updated comment documenting the ZTWIM override path is helpful.

configMapName: "spire-bundle"
configMapNamespace: ""
configMapKey: "bundle.crt"
configMapKey: "bundle.spiffe"
refreshInterval: "5m"
# How far before SVID expiry to trigger proactive workload restart
svidExpiryGracePeriod: "30m"