fix: update proactive restart demo defaults to match Helm conventions#244
Open
fix: update proactive restart demo defaults to match Helm conventions#244
Conversation
Update OPERATOR_NS and OPERATOR_DEPLOY defaults in the proactive restart demo scripts to match the Helm chart conventions (kagenti-system and kagenti-controller-manager) instead of the legacy agentcard-system and agentcard-operator values. Fixes #223 Signed-off-by: cwiklik <cwiklikj@gmail.com> Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
cwiklik
force-pushed
the
fix/223-demo-script-defaults
branch
from
0ca0d52 to
ab42c41
Compare
rubambiza
approved these changes
Mar 27, 2026
Contributor
rubambiza
left a comment
rubambiza
left a comment
There was a problem hiding this comment.
Straightforward default rename to match post-rebrand Helm conventions. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPERATOR_NSdefault fromagentcard-systemtokagenti-systemOPERATOR_DEPLOYdefault fromagentcard-operatortokagenti-controller-managerrun-demo-commands.shandteardown-demo.shFixes #223
Test plan
demos/agentcard-proactive-restart/run-demo-commands.shafter a Helm-based install without env var overridesteardown-demo.shrestores the operator correctlyAssisted-By: Claude (Anthropic AI) noreply@anthropic.com