Conversation
huang195
left a comment
There was a problem hiding this comment.
Mostly looks good. A few suggestions.
AuthBridge/BLOG-agentic.md
Outdated
| ``` | ||
|
|
||
| <details> | ||
| <summary><b>📊 Mermaid Diagram</b></summary> |
There was a problem hiding this comment.
The mermaid diagram and the ascii diagram above are the same. Is this the intention?
There was a problem hiding this comment.
Right, I would like to get your opinion on how to present this for the Blog. I can draw the boxes using draw.io to shapes as represented in ASCII chart, or we can use the marmaid graphs.
There was a problem hiding this comment.
I think ascii pictures look fine in marked down files, but it would look weird in an actual blog. But the diagram is simple enough, so either one would work.
| self.token = None | ||
| self.token_expiry = None | ||
|
|
||
| def get_token(self): |
There was a problem hiding this comment.
I know this is psuedo code, but do we mean exchange_token() instead of get_token() here?
There was a problem hiding this comment.
There is self.exchange_token below, using the token obtained here.
There was a problem hiding this comment.
OK, I see. I didn't see exchange_token() was defined anywhere, so I thought you meant get_token(). Do we need to write any pseudo code around exchange_token() since we're trying to highlight complexities?
|
@mrsabath is the blog MD file meant to be converted to a Medium blog eventually? If so, we can merge this PR, and do additional feedbacks once the blog draft is ready. |
|
Adding the link to the Medium Blog: https://medium.com/@mrsabath/1408d7384a1e |
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
7889fd5 to
9d2be26
Compare
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. If this PR is still relevant, please comment or remove the stale label. |
Description
Fixes # (issue)
Type of Change
How Has This Been Tested?
Test Configuration:
Checklist
Screenshots (if appropriate)
Additional Notes