Skip to content

docs: Drafting AuthBridge Blog#61

Draft
mrsabath wants to merge 16 commits intokagenti:mainfrom
mrsabath:authbridge-blog
Draft

docs: Drafting AuthBridge Blog#61
mrsabath wants to merge 16 commits intokagenti:mainfrom
mrsabath:authbridge-blog

Conversation

@mrsabath
Copy link
Copy Markdown
Contributor

Description

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test addition or update
  • CI/CD update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Kubernetes version:
  • Toolhive webhook version:
  • OS:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if appropriate)

Additional Notes

Copy link
Copy Markdown
Contributor

@huang195 huang195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. A few suggestions.

```

<details>
<summary><b>📊 Mermaid Diagram</b></summary>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mermaid diagram and the ascii diagram above are the same. Is this the intention?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I would like to get your opinion on how to present this for the Blog. I can draw the boxes using draw.io to shapes as represented in ASCII chart, or we can use the marmaid graphs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ascii pictures look fine in marked down files, but it would look weird in an actual blog. But the diagram is simple enough, so either one would work.

self.token = None
self.token_expiry = None

def get_token(self):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is psuedo code, but do we mean exchange_token() instead of get_token() here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is self.exchange_token below, using the token obtained here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see. I didn't see exchange_token() was defined anywhere, so I thought you meant get_token(). Do we need to write any pseudo code around exchange_token() since we're trying to highlight complexities?

@huang195
Copy link
Copy Markdown
Contributor

@mrsabath is the blog MD file meant to be converted to a Medium blog eventually? If so, we can merge this PR, and do additional feedbacks once the blog draft is ready.

@mrsabath
Copy link
Copy Markdown
Contributor Author

Adding the link to the Medium Blog: https://medium.com/@mrsabath/1408d7384a1e

Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. If this PR is still relevant, please comment or remove the stale label.

@github-actions github-actions bot added the stale label Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants