Skip to content

Feature: Deployment descriptor and README for weather agent and weather tool#195

Merged
esnible merged 4 commits intokagenti:mainfrom
esnible:deployment-for-weather-svc-and-tool
Mar 24, 2026
Merged

Feature: Deployment descriptor and README for weather agent and weather tool#195
esnible merged 4 commits intokagenti:mainfrom
esnible:deployment-for-weather-svc-and-tool

Conversation

@esnible
Copy link
Copy Markdown
Contributor

@esnible esnible commented Mar 23, 2026

Summary

This PR follows the approach of #186 by introducing Kubernetes deployment descriptors.

I use these to quickly spin up a working weather agent for testing. The examples are also documented, which should help humans and LLMs understand how Kagenti deployments should look.

(Optional) Testing Instructions

  • kubectl apply -f mcp/weather_tool/deployment/k8s.yaml
  • kubectl apply -f a2a/weather_service/deployment/k8s.yaml
  • Reload the Kagenti Agent page. The weather service should be present, start chatting with it.

esnible added 2 commits March 23, 2026 10:38
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible requested a review from a team as a code owner March 23, 2026 16:02
esnible added 2 commits March 23, 2026 11:52
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
Copy link
Copy Markdown
Collaborator

@cwiklik cwiklik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-structured PR adding production-ready Kubernetes deployment examples for the weather service (A2A) and weather tool (MCP). Security best practices are consistently applied: non-root containers, dropped capabilities, seccomp profiles, dedicated ServiceAccounts, resource limits. The READMEs provide clear deployment instructions with multiple paths (local dev, UI, kubectl).

Areas reviewed: YAML/K8s, Docs, Security, .dockerignore
Commits: 4 commits, all signed-off ✓
CI status: All passing ✓

Suggestions (non-blocking):

  • Consider adding a readiness probe to the weather tool manifest (acknowledged in comment already) — since these examples get copied, showing the full pattern helps.
  • imagePullPolicy: Always makes sense for alpha tags; a brief comment noting IfNotPresent for stable releases could help users adapting the example.

Good fix in currency_converter aligning the commented Secret example to LLM_API_KEY. Excellent security context pattern throughout — great reference material.

@esnible esnible merged commit 5296fa8 into kagenti:main Mar 24, 2026
9 checks passed
@esnible esnible deleted the deployment-for-weather-svc-and-tool branch March 24, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants