Feature: Deployment descriptor and README for weather agent and weather tool#195
Merged
esnible merged 4 commits intokagenti:mainfrom Mar 24, 2026
Merged
Conversation
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
cwiklik
approved these changes
Mar 24, 2026
Collaborator
cwiklik
left a comment
There was a problem hiding this comment.
Well-structured PR adding production-ready Kubernetes deployment examples for the weather service (A2A) and weather tool (MCP). Security best practices are consistently applied: non-root containers, dropped capabilities, seccomp profiles, dedicated ServiceAccounts, resource limits. The READMEs provide clear deployment instructions with multiple paths (local dev, UI, kubectl).
Areas reviewed: YAML/K8s, Docs, Security, .dockerignore
Commits: 4 commits, all signed-off ✓
CI status: All passing ✓
Suggestions (non-blocking):
- Consider adding a readiness probe to the weather tool manifest (acknowledged in comment already) — since these examples get copied, showing the full pattern helps.
imagePullPolicy: Alwaysmakes sense for alpha tags; a brief comment notingIfNotPresentfor stable releases could help users adapting the example.
Good fix in currency_converter aligning the commented Secret example to LLM_API_KEY. Excellent security context pattern throughout — great reference material.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows the approach of #186 by introducing Kubernetes deployment descriptors.
I use these to quickly spin up a working weather agent for testing. The examples are also documented, which should help humans and LLMs understand how Kagenti deployments should look.
(Optional) Testing Instructions
kubectl apply -f mcp/weather_tool/deployment/k8s.yamlkubectl apply -f a2a/weather_service/deployment/k8s.yaml