feat: refactor agent skills and support OpenAI Agents SDK #1100

supreme-gg-gg · 2025-11-12T07:22:59Z

Completes #1068

Integrates OpenAI SDK (fixed event converters, session service, tools, tracing) and added e2e test for OpenAI SDK
Refactor skills prompt and tool logic into kagent-skills, update ADK and OpenAI SDK to wrap them with their functions tool implementations
Improvements to handling bash tool venv and python path

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Jet Chiang <jetjiang.ez@gmail.com>

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

Copilot

Pull request overview

This pull request refactors agent skills architecture and adds OpenAI Agents SDK support by creating a centralized kagent-skills package that both ADK and OpenAI integrations can leverage. The refactoring improves code reusability and maintainability while enabling OpenAI agents to utilize the same skills infrastructure as ADK agents.

Key Changes:

Created kagent-skills package with core skills logic (discovery, session management, shell operations, prompts)
Added kagent-openai package with OpenAI Agents SDK integration including tools, session service, event conversion, and agent executor
Refactored kagent-adk to use shared skills package, removing duplicated code

Reviewed changes

Copilot reviewed 50 out of 54 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
`python/packages/kagent-skills/`	New centralized package for skills discovery, file operations, shell execution, and session management
`python/packages/kagent-openai/`	New OpenAI SDK integration with A2A protocol support, session persistence, and tools
`python/samples/openai/basic_agent/`	Sample OpenAI agent demonstrating calculator and weather tools
`python/packages/kagent-adk/src/kagent/adk/tools/`	Refactored to use kagent-skills package instead of local implementations
`python/packages/kagent-crewai/`	Import order fixes and CrewAI version update to >= 1.2.0
`python/Dockerfile`	Added kagent-skills package, updated PYTHONPATH and venv configuration
`go/test/e2e/`	Added e2e tests for OpenAI agent invocation with mocked LLM responses
`python/pyproject.toml`	Added samples/openai to workspace members

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-04T21:54:14Z

python/packages/kagent-skills/src/kagent/skills/shell.py

+
+        try:
+            stdout, stderr = await asyncio.wait_for(process.communicate(), timeout=timeout)
+        except TimeoutError:


The TimeoutError exception should be asyncio.TimeoutError for clarity and to avoid potential conflicts with the built-in TimeoutError (added in Python 3.10). While they may be the same in Python 3.13+, being explicit improves code clarity.

Change:

except TimeoutError:

to:

except asyncio.TimeoutError:

Copilot · 2025-12-04T21:54:14Z

python/Dockerfile

 # Create a separate venv for bash tool commands (sandbox environment)
+# This venv does not have pip installed


The comment on line 118 states "This venv does not have pip installed" but this is misleading. The bash tool description in prompts.py mentions "pip install" with a 120s timeout, and the _get_command_timeout_seconds function specifically handles "pip install" commands. If pip is not installed in the sandbox venv, then pip install commands will fail, making the timeout configuration useless.

Either:

Install pip in the sandbox venv, OR

Remove pip-related timeout logic and documentation if pip is intentionally excluded

Copilot · 2025-12-04T21:54:15Z

python/packages/kagent-openai/src/kagent/openai/tools/_tools.py

+            footer = (
+                "\n\n---"
+                "The skill has been loaded. Follow the instructions above and use the bash tool to execute commands."
+            )


Missing a newline after the "---" separator on line 158. The footer should be:

footer = ( "\n\n---\n" "The skill has been loaded. Follow the instructions above and use the bash tool to execute commands." )

This ensures proper markdown formatting with whitespace before and after the horizontal rule.

Copilot · 2025-12-04T21:54:15Z

go/test/e2e/mocks/invoke_openai_agent.json

+            "index": 0,
+            "message": {
+              "role": "assistant",
+              "content": "The weather in london is Rainy, 52°F"


Inconsistent spelling: "london" should be capitalized to "London" to match the input and be consistent with the rest of the response. The weather data uses "london" as the key (line 58) which is fine for internal lookup, but the response should preserve the proper capitalization.

Change line 122 from:

"content": "The weather in london is Rainy, 52°F"

to:

"content": "The weather in London is Rainy, 52°F"

Suggested change

"content": "The weather in london is Rainy, 52°F"

"content": "The weather in London is Rainy, 52°F"

Copilot · 2025-12-04T21:54:15Z

python/Dockerfile

 ENV PATH="/.kagent/.venv/bin:$PATH"
-ENV UV_PROJECT_ENVIRONMENT=/app/.venv
-ENV BASH_VENV_PATH="/.kagent/sandbox-venv"
+ENV PYTHONPATH="/.kagent:/"


Inconsistent environment variable naming: The Dockerfile uses PYTHONPATH=/.kagent:/ (line 126) which adds /.kagent to the path, but the kagent-skills shell.py adds the working directory and /skills to PYTHONPATH (line 124). This could lead to import confusion.

The /.kagent path in the Dockerfile doesn't seem to be referenced anywhere else in the codebase, and it's unclear what should be imported from there. Consider documenting why /.kagent needs to be on PYTHONPATH or removing it if it's not necessary.

Suggested change

ENV PYTHONPATH="/.kagent:/"

Copilot · 2025-12-04T21:54:16Z

python/packages/kagent-skills/src/kagent/skills/shell.py

+    bash_venv_path = os.environ.get("BASH_VENV_PATH")
+    if bash_venv_path:
+        bash_venv_bin = os.path.join(bash_venv_path, "bin")
+        # Prepend bash venv to PATH so its python and pip are used
+        env["PATH"] = f"{bash_venv_bin}:{env.get('PATH', '')}"
+        env["VIRTUAL_ENV"] = bash_venv_path


Missing error handling for the case when BASH_VENV_PATH environment variable is set but the path doesn't exist or is invalid. If bash_venv_path is set but the directory doesn't exist, this could lead to the command failing with unclear errors.

Consider adding validation:

if bash_venv_path: if not os.path.exists(bash_venv_path): logger.warning(f"BASH_VENV_PATH {bash_venv_path} does not exist, using system python") else: bash_venv_bin = os.path.join(bash_venv_path, "bin") env["PATH"] = f"{bash_venv_bin}:{env.get('PATH', '')}" env["VIRTUAL_ENV"] = bash_venv_path

Copilot · 2025-12-04T21:54:16Z

python/packages/kagent-openai/src/kagent/openai/_agent_executor.py

+                timeout=self._config.execution_timeout,
+            )
+
+        except TimeoutError:


The TimeoutError exception should be asyncio.TimeoutError for clarity and consistency. While they may be the same in Python 3.13+, being explicit about using asyncio's TimeoutError improves code clarity, especially since asyncio.wait_for is being used above.

Change line 284 from:

except TimeoutError:

to:

except asyncio.TimeoutError:

Suggested change

except TimeoutError:

except asyncio.TimeoutError:

Copilot · 2025-12-04T21:54:17Z

python/packages/kagent-adk/src/kagent/adk/tools/__init__.py

+    "SkillsTool",
+    "SkillsPlugin",
+    "SkillsToolset",
+    "generate_shell_skills_system_prompt",


The name 'generate_shell_skills_system_prompt' is exported by all but is not defined.

Copilot · 2025-12-04T21:54:17Z

python/packages/kagent-core/src/kagent/core/tracing/_utils.py

+            AnthropicInstrumentor(use_legacy_attributes=False).instrument(event_logger_provider=event_logger_provider)
+        else:
+            AnthropicInstrumentor().instrument()
+    except ImportError:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2025-12-04T21:54:17Z

python/packages/kagent-core/src/kagent/core/tracing/_utils.py

+        from opentelemetry.instrumentation.google_generativeai import GoogleGenerativeAiInstrumentor
+
+        GoogleGenerativeAiInstrumentor().instrument()
+    except ImportError:


'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

except ImportError:

except ImportError:

# Google GenerativeAI SDK is not installed; skipping instrumentation.

EItanya and others added 13 commits December 4, 2025 00:29

feat: add skeleton of openai-agent skills

5fa5cb3

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Jet Chiang <jetjiang.ez@gmail.com>

refactor kagent skills with basic tests

d250df5

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

cleanup some kagent openai

070daa9

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

use kagent skills in adk

b65734e

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

create session tmp working dir in openai executor

1a2f7f2

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

fixes to kagent openai

0d1de62

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

minor fixes to other packages

db4c68d

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

e2e test for openai

7b2f525

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

refactor kagent adk

22beaae

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

improvements to python path and path

6fe9af6

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

update openai sdk

78c3a4c

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

fix openai sample and add to makefile

98041dd

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

restore files from main

4a64f40

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

supreme-gg-gg force-pushed the feat/openai-agents branch from d449fe2 to 5b78fd3 Compare December 4, 2025 05:49

supreme-gg-gg changed the title ~~Refactor agent skills and support OpenAI Agents SDK~~ (feat) refactor agent skills and support OpenAI Agents SDK Dec 4, 2025

supreme-gg-gg changed the title ~~(feat) refactor agent skills and support OpenAI Agents SDK~~ feat: refactor agent skills and support OpenAI Agents SDK Dec 4, 2025

supreme-gg-gg added 4 commits December 4, 2025 16:38

fix ci

9d05ca3

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

update dockerfile to initialize new venv with pip

3d1136a

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

remove pip from bash venv

38f97b9

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

fix e2e and lint

e1071ed

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

supreme-gg-gg force-pushed the feat/openai-agents branch from 39b1844 to e1071ed Compare December 4, 2025 21:39

python lint

9fafbb5

Signed-off-by: Jet Chiang <jetjiang.ez@gmail.com>

supreme-gg-gg marked this pull request as ready for review December 4, 2025 21:45

supreme-gg-gg requested a review from EItanya as a code owner December 4, 2025 21:45

Copilot AI review requested due to automatic review settings December 4, 2025 21:45

supreme-gg-gg requested review from ilackarms, peterj and yuval-k as code owners December 4, 2025 21:45

Copilot started reviewing on behalf of supreme-gg-gg December 4, 2025 21:45 View session

Copilot finished reviewing on behalf of supreme-gg-gg December 4, 2025 21:47

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: refactor agent skills and support OpenAI Agents SDK #1100

feat: refactor agent skills and support OpenAI Agents SDK #1100

Uh oh!

supreme-gg-gg commented Nov 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		# Create a separate venv for bash tool commands (sandbox environment)
		# This venv does not have pip installed

	"content": "The weather in london is Rainy, 52°F"
	"content": "The weather in London is Rainy, 52°F"

	except ImportError:
	except ImportError:
	# Google GenerativeAI SDK is not installed; skipping instrumentation.

feat: refactor agent skills and support OpenAI Agents SDK #1100

Are you sure you want to change the base?

feat: refactor agent skills and support OpenAI Agents SDK #1100

Uh oh!

Conversation

supreme-gg-gg commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

supreme-gg-gg commented Nov 12, 2025 •

edited

Loading