fix(helm): model config for multiple providers #1094
+58
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate **multiple ModelConfig resources** (one per provider) instead of just one for the default provider. Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
nlamirault
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
EItanya
reviewed
Nov 6, 2025
Contributor
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
This is a very interesting idea I like it! I will try and get to a deeper review ASAP but it may be after KubeCon as there is A LOT happening the next few work days.
Contributor
|
maybe we should add range over additional models of the same provider ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate multiple ModelConfig resources (one per provider) instead of just one for the default provider.