feature(helm): Add support for affinities for main deployments #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds affinity configuration support to multiple Helm charts, enabling users to configure pod affinity rules for better workload placement control in Kubernetes deployments.
- Adds
affinityconfiguration fields to values files for querydoc, grafana-mcp, and kagent charts - Implements affinity settings in corresponding deployment templates
- Provides consistent configuration options across different chart components
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/tools/querydoc/values.yaml | Adds affinity configuration field with empty default |
| helm/tools/querydoc/templates/deployment.yaml | Implements affinity template block in pod spec |
| helm/tools/grafana-mcp/values.yaml | Adds affinity configuration field with empty default |
| helm/tools/grafana-mcp/templates/deployment.yaml | Implements affinity template block in pod spec |
| helm/kagent/values.yaml | Adds affinity configuration fields for root, controller, ui, and kagent-tools components with documentation comments |
| helm/kagent/templates/ui-deployment.yaml | Implements affinity template block for ui component |
| helm/kagent/templates/controller-deployment.yaml | Implements affinity template block for controller component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dhouti <l.rex.via@gmail.com>
Dhouti
force-pushed
the
feature/helm-support-affinities
branch
from
585e10e to
80ad7cc
Compare
EItanya
requested changes
Nov 12, 2025
| # -- Node labels to match for `Pod` [scheduling](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/). | ||
| nodeSelector: {} | ||
|
|
||
| # Affintities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ |
Contributor
There was a problem hiding this comment.
Suggested change
| # Affintities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ | |
| # Affinities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ |
| # -- Node labels to match for `Pod` [scheduling](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/). | ||
| nodeSelector: {} | ||
|
|
||
| # Affintities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ |
Contributor
There was a problem hiding this comment.
Suggested change
| # Affintities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ | |
| # Affinities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ |
| # -- Node labels to match for `Pod` [scheduling](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/). | ||
| nodeSelector: {} | ||
|
|
||
| # Affintities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ |
Contributor
There was a problem hiding this comment.
Suggested change
| # Affintities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ | |
| # Affinities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ |
Comment on lines
+221
to
+228
| # -- Node taints which will be tolerated for `Pod` [scheduling](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/). | ||
| tolerations: [] | ||
|
|
||
| # -- Node labels to match for `Pod` [scheduling](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/). | ||
| nodeSelector: {} | ||
|
|
||
| # Affintities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ | ||
| affinity: {} |
Contributor
There was a problem hiding this comment.
In order for these to take effect you'll have to update the helm chart for the tools in https://github.com/kagent-dev/tools
Comment on lines
+43
to
+50
| # -- Node taints which will be tolerated for `Pod` [scheduling](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/). | ||
| tolerations: [] | ||
|
|
||
| # -- Node labels to match for `Pod` [scheduling](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/). | ||
| nodeSelector: {} | ||
|
|
||
| # Affinities for `Pod` https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/ | ||
| affinity: {} |
Contributor
There was a problem hiding this comment.
Are these actually used anywhere? The templates seem to just check their namespaces values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm charts do not currently support
affinity.This PR adds basic support for scheduling the main workloads with affinities.
This is sometimes an ideal choice over
nodeSelector.Ideally these would also be added to the
toolsandkmcpcharts.