-
Notifications
You must be signed in to change notification settings - Fork 349
chore(kagent-adk/session_service): add logging for Kagent API errors #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds consistent error logging for HTTP API failures in the Kagent session service to improve debugging and monitoring capabilities. The changes wrap existing HTTP status error handling with try-catch blocks that log the response text before re-raising the exceptions.
- Adds error logging for all HTTP API failures in session operations
- Maintains existing error handling behavior while adding visibility into failure details
- Uses consistent logging format across all session service methods
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
thanks for the PR @mozillazg . can you address the copilot comments? |
@peterj Yes, I'll address the comments. |
Signed-off-by: Huang Huang <mozillazg101@gmail.com>
Signed-off-by: mozillazg <mozillazg101@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: mozillazg <mozillazg101@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.