Skip to content

Conversation

@mozillazg
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 20, 2025 08:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds consistent error logging for HTTP API failures in the Kagent session service to improve debugging and monitoring capabilities. The changes wrap existing HTTP status error handling with try-catch blocks that log the response text before re-raising the exceptions.

  • Adds error logging for all HTTP API failures in session operations
  • Maintains existing error handling behavior while adding visibility into failure details
  • Uses consistent logging format across all session service methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@peterj
Copy link
Collaborator

peterj commented Oct 20, 2025

thanks for the PR @mozillazg . can you address the copilot comments?

@mozillazg mozillazg changed the title chore(kagent-adk/session_sevice): add logging for Kagent API errors chore(kagent-adk/session_service): add logging for Kagent API errors Oct 29, 2025
@mozillazg
Copy link
Contributor Author

thanks for the PR @mozillazg . can you address the copilot comments?

@peterj Yes, I'll address the comments.

Signed-off-by: Huang Huang <mozillazg101@gmail.com>
Signed-off-by: mozillazg <mozillazg101@gmail.com>
Signed-off-by: mozillazg <mozillazg101@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: mozillazg <mozillazg101@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mozillazg mozillazg marked this pull request as ready for review November 15, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants