Skip to content

Removed default parameters from implementation file #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpochwala wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed default parameters from implementation file #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/ezLED.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

#include <ezLED.h>

ezLED::ezLED(int pin, int mode = CTRL_ANODE) {
ezLED::ezLED(int pin, int mode) {
_ledPin = pin;
_ctrlMode = mode; // CTRL_ANODE, CTRL_CATHODE
_ledMode = LED_MODE_OFF;
Expand Down Expand Up @@ -78,7 +78,7 @@ void ezLED::updateDigital() {
digitalWrite(_ledPin, state);
}

void ezLED::turnON(unsigned long delayTime = 0) {
void ezLED::turnON(unsigned long delayTime) {
_delayTime = delayTime;
_ledMode = LED_MODE_ON;

Expand All @@ -92,7 +92,7 @@ void ezLED::turnON(unsigned long delayTime = 0) {
loop();
}

void ezLED::turnOFF(unsigned long delayTime = 0) {
void ezLED::turnOFF(unsigned long delayTime) {
_delayTime = delayTime;
_ledMode = LED_MODE_OFF;

Expand All @@ -106,7 +106,7 @@ void ezLED::turnOFF(unsigned long delayTime = 0) {
loop();
}

void ezLED::toggle(unsigned long delayTime = 0) {
void ezLED::toggle(unsigned long delayTime) {
_delayTime = delayTime;
_ledMode = LED_MODE_TOGGLE;

Expand All @@ -122,7 +122,7 @@ void ezLED::toggle(unsigned long delayTime = 0) {
}


void ezLED::fade(int fadeFrom, int fadeTo, unsigned long fadeTime, unsigned long delayTime = 0) {
void ezLED::fade(int fadeFrom, int fadeTo, unsigned long fadeTime, unsigned long delayTime) {
_fadeFrom = fadeFrom;
_fadeTo = fadeTo;
_fadeTime = fadeTime;
Expand All @@ -138,7 +138,7 @@ void ezLED::fade(int fadeFrom, int fadeTo, unsigned long fadeTime, unsigned long
loop();
}

void ezLED::blink(unsigned long onTime, unsigned long offTime, unsigned long delayTime = 0) {
void ezLED::blink(unsigned long onTime, unsigned long offTime, unsigned long delayTime) {
setBlink(onTime, offTime, delayTime);
_ledMode = LED_MODE_BLINK_FOREVER;

Expand All @@ -156,7 +156,7 @@ void ezLED::blink(unsigned long onTime, unsigned long offTime, unsigned long del
loop();
}

void ezLED::blinkInPeriod(unsigned long onTime, unsigned long offTime, unsigned long blinkTime, unsigned long delayTime = 0) {
void ezLED::blinkInPeriod(unsigned long onTime, unsigned long offTime, unsigned long blinkTime, unsigned long delayTime) {
setBlink(onTime, offTime, delayTime);
_blinkTimePeriod = blinkTime;
_ledMode = LED_MODE_BLINK_PERIOD;
Expand All @@ -176,7 +176,7 @@ void ezLED::blinkInPeriod(unsigned long onTime, unsigned long offTime, unsigned
loop();
}

void ezLED::blinkNumberOfTimes(unsigned long onTime, unsigned long offTime, unsigned int numberOfTimes, unsigned long delayTime = 0) {
void ezLED::blinkNumberOfTimes(unsigned long onTime, unsigned long offTime, unsigned int numberOfTimes, unsigned long delayTime) {
setBlink(onTime, offTime, delayTime);
_blinkNumberOfTimes = numberOfTimes;
_ledMode = LED_MODE_BLINK_NUM_TIME;
Expand Down