Open
Conversation
This fixes false positives that produce warning spam. This is especially annoying for attributes templates, which can be stringified via patchOuter().
* Fix compilation issues with TypeScript 4.4. Typescript 4.4 removes namespaceURI from the Node interface as it's not present there for all Node types. This change is documented in: microsoft/TypeScript-DOM-lib-generator#1029 * Update nodes.ts
The change to make the code compatible with TypeScript 4.4 broke SVG rendering in certain cases in Chrome.
Use "@license SPDX-License-Identifier" instead of long form license to reduce bloat in compiled builds.
This includes: - Adding a .bazelignore so building `...` doesn't try to build the node_modules directory. - Removing a bazelrc flag that no longer exists and isn't needed anymore. - Switching to a modern rollup_bundle implementation. This requires: - Adding a config file to set the global name and license banner. - Generating output formats separately, since it no longer generates all of them. - Using the Rollup Buble plugin to downlevel (transpile) to ES5. - Switching npm_package to the modern pkg_npm. - This cleans up some "replacements" (formerly called "substitutions") - Switching from `bazel` to `bazelisk` as `bazel` is now [deprecated](https://www.npmjs.com/package/@bazel/bazel) for this use case. - Upgrading to rules_nodejs version 4.6.0. - Switching `ts_web_test` to the modern `karma_web_test` (which is in the `@bazel/concatjs` package). The JS output is roughly the same. There are some small changes related to variable renaming and optimizations that shouldn't affect runtime behavior. The main difference is that the const `DEBUG` replacements now work (before the `DEBUG` const got inlined before the replacement step).
This disables Chrome's sandbox when the test in run on macOS. It's unclear why this is necessary, but it does fix the test. https://gist.github.com/mattem/f6e85437b0dbcca661013a19247889a9#file-karma-conf-js-L49 does something similar. The error in Chrome's logs is "SeatbeltExecServer: Failed to initialize sandbox: -1 Operation not permitted". I couldn't get any more details about the failure or find any details about it online. I don't think sandboxing should matter for these tests though, since it's a security feature.
Co-authored-by: Eric Spishak-Thomas <spishak@google.com>
This is useful for Soy functions that cun run in both idom and classic contexts.
Removing some extra words.
* Pierce ShadowRoot boundary when getting ancestry With on-demand ShadyDOM, the DOM is rendered without shadow nodes, but the API acts as if these shadow nodes exist. This can cause issues with getFocusedPath calls where the activeElement is inside of a "shadow node", thus getting the ancestry of the activeElement to the root results in an assertion error because `n.parentNode` returns undefined. We can get around this by piercing through the shadow node boundary. This should only affect on-demand ShadyDOM since for regular ShadowDOM, the `!node.contains(activeElement)` check would be true causing getFocusedPath to short circuit. * Remove unecessary optional chaining
In the case that the root is null, getAncestry shouldn't pierce through the shadow DOM. This only happens when `node.parentNode` is null, which only happens when the node is a document fragment or ShadowRoot.
attachShadow is part of the shadowDOM v1 spec, createShadow no longer works.
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) to 4.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be updated together. Updates `socket.io-parser` from 3.2.0 to 4.2.1 - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@3.2.0...4.2.1) Updates `karma` from 4.2.0 to 6.4.1 - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v4.2.0...v6.4.1) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect - dependency-name: karma dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )