Skip to content

Add extra args support #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nobleess wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add extra args support #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/v1alpha1/vector_common_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ type VectorCommon struct {
CompressConfigFile bool `json:"compressConfigFile,omitempty"`
ConfigReloaderImage string `json:"configReloaderImage,omitempty"`
ConfigReloaderResources v1.ResourceRequirements `json:"configReloaderResources,omitempty"`
Args []string `json:"args,omitempty"`
}

// ApiSpec is the Schema for the Vector Agent GraphQL API - https://vector.dev/docs/reference/api/
Expand Down
5 changes: 5 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions config/crd/bases/observability.kaasops.io_clustervectoraggregators.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,10 @@ spec:
playground:
type: boolean
type: object
args:
items:
type: string
type: array
compressConfigFile:
description: 'Compress config file to fix: metadata.annotations: Too
long: must have at most 262144 characters'
Expand Down
4 changes: 4 additions & 0 deletions config/crd/bases/observability.kaasops.io_vectoraggregators.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,10 @@ spec:
playground:
type: boolean
type: object
args:
items:
type: string
type: array
compressConfigFile:
description: 'Compress config file to fix: metadata.annotations: Too
long: must have at most 262144 characters'
Expand Down
4 changes: 4 additions & 0 deletions config/crd/bases/observability.kaasops.io_vectors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,6 +998,10 @@ spec:
playground:
type: boolean
type: object
args:
items:
type: string
type: array
compressConfigFile:
description: 'Compress config file to fix: metadata.annotations:
Too long: must have at most 262144 characters'
Expand Down
3 changes: 3 additions & 0 deletions helm/charts/vector-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ vector:
# env:
# - name: "testenv"
# value: "testvalues"
# args:
# --allocation-tracing


secrets: {}
# - name: elastic-creds
Expand Down
2 changes: 1 addition & 1 deletion internal/vector/vectoragent/vectoragent_daemonset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ func (ctrl *Controller) VectorAgentContainer() *corev1.Container {
container := &corev1.Container{
Name: ctrl.getNameVectorAgent(),
Image: ctrl.Vector.Spec.Agent.Image,
Args: []string{"--config-dir", "/etc/vector", "--watch-config"},
Args: append([]string{"--config-dir", "/etc/vector", "--watch-config"}, ctrl.Vector.Spec.Agent.Args...),
Env: ctrl.generateVectorAgentEnvs(),
Ports: []corev1.ContainerPort{
{
Expand Down