fix: do not create empty PVC when storage has only volumeMount #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When spec.storage contains only volumeMount entries (e.g. emptyDir) without volumeClaimTemplate, the operator incorrectly set PersistenceEnabled=true, causing an empty volumeClaimTemplates entry in the StatefulSet. Check whether volumeClaimTemplate is actually populated before enabling persistence. Signed-off-by: Aleksandrov Aleksandr <aaleksandrov.cy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
spec.storagecontains onlyvolumeMountentries (e.g.emptyDir) withoutvolumeClaimTemplate, the operator incorrectly setPersistenceEnabled=true, causing an emptyvolumeClaimTemplatesentry in the resulting StatefulSet. This led to unnecessary (and possibly broken) PVC provisioning.Root cause:
PersistenceEnabledwas set based solely oncr.Spec.Storage != nil, without checking whethervolumeClaimTemplateis actually populated. Since theStoragestruct is non-nil whenever any storage is configured (including volumeMount-only with emptyDir), the operator always treated it as a request for a PersistentVolumeClaim.Changes:
storageHasVolumeClaimTemplate()helper instatefulset.gothat checks whetherVolumeClaimTemplatehas meaningful content (AccessModes,Resources.Requests,StorageClassName, orVolumeName)cr.Spec.Storage != nilwithstorageHasVolumeClaimTemplate()for both container and init container paramsPersistenceEnabled != nil && *PersistenceEnabled)storageHasVolumeClaimTemplateType of change
Checklist
Additional Context
Users who have
volumeClaimTemplateproperly configured are not affected — behavior is unchanged for them. The fix only removes the incorrect empty PVC creation for volumeMount-only storage configurations.