volume: check if starting with /` instead of using Path::is_absolute
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Podman is only running on UNIX-like systems; even on Windows, it is running inside WSLv2. Thus, its check for absolute path will always only check if said path starts with a `/`. On non-UNIX platform (e.g. WASM), `Path::is_absolute` will return `false` for paths starting with `/`, which is not what we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman is only running on UNIX-like systems; even on Windows, it is running inside WSLv2. Thus, its check for absolute path will always only check if said path starts with a
/. On non-UNIX platform (e.g. WASM),Path::is_absolutewill returnfalsefor paths starting with/, which is not what we want.I'm currently making a WASM wrapper around podlet to generate Quadlet files in the browser, and this is currently blocking me.
Just found out when making this PR that #40 might propose a more complete fix, but this one is simpler to review since #40 hasn't moved since february