Skip to content

Conversation

@wahabmk
Copy link
Contributor

@wahabmk wahabmk commented Feb 9, 2026

Description

Kindly see the description of the bug in the linked issue. The fix that this PR proposes is explained by the following scenario:

  • Let's say a CD or MCS with services A<-(B,C) has been created, i.e: B and C depend on A.
  • The controller will first add A to the ServiceSet.
  • Then B & C are added to ServiceSet once A is successfully deployed.
  • So all 3 services eventually become successfully deployed.
  • Now let's say for some reason the state of A changes to !Deployed (maybe Failed or Provisioning) in the ClusterSummary.
  • Now the poller is triggered again to reconcile the ServiceSet.
  • The ServiceSet is updated with the latest state of services from ClusterSummary, this in-turn triggers the CD or MCS controller.
  • Originally the controller would only include A in the ServiceSet because A's current state doesn't show Deployed and B & C depend on A so they shouldn't be added to the ServiceSet until A has been deployed (the bug)
  • Now with this change, once the controller observes that A's state is !Deployed, it will check if any of A's dependents already exist in the current ServiceSet's spec. If yes, then that means A was successfully deployed in the past, therefore, it will add all of A's dependents to the ServiceSet even if currently A's state shows !Deployed.

Fixes: #2377.

@wahabmk wahabmk linked an issue Feb 9, 2026 that may be closed by this pull request
@wahabmk wahabmk force-pushed the fix-dependson-bug branch 3 times, most recently from 7511b86 to d863dc6 Compare February 11, 2026 13:24
@wahabmk wahabmk changed the title fix: bug in service dependson where services are undeployed fix: bug in service dependsOn where services become !Deployed Feb 11, 2026
Signed-off-by: Wahab Ali <wahabalimk@gmail.com>
@wahabmk wahabmk marked this pull request as ready for review February 11, 2026 13:51
@wahabmk wahabmk self-assigned this Feb 11, 2026
@wahabmk wahabmk added the test e2e Runs the entire provider E2E test suite, controller E2E tests are always ran label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test e2e Runs the entire provider E2E test suite, controller E2E tests are always ran

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Services depending on another restarted

1 participant