feat: add option to disable gateway resource creation #35
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Adds a Helm values toggle to optionally skip deploying the default Istio Gateway resource, enabling externally-managed/custom Gateways without collisions.
Changes:
- Introduces
gateway.resource.enabled(defaulttrue) in chart values. - Wraps Gateway-related templates/entries with conditionals to skip rendering when disabled.
- Ensures the ConfigMap template renders the Gateway manifest without the
enabledkey.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| charts/k0rdent-istio/values.yaml | Adds gateway.resource.enabled flag to control Gateway resource deployment. |
| charts/k0rdent-istio/templates/gateway/svctmpl.yaml | Conditionally renders the ServiceTemplate based on the new flag. |
| charts/k0rdent-istio/templates/gateway/mcs.yaml | Conditionally includes the gateway-template entry in the MCS spec. |
| charts/k0rdent-istio/templates/gateway/cm-template.yaml | Gates ConfigMap rendering on management mode + enabled flag; omits enabled from serialized Gateway. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndrejsPon00
force-pushed
the
disable-gateway-resource
branch
from
d7654dc to
85e78f7
Compare
denis-ryzhkov
approved these changes
Feb 12, 2026
gmlexx
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to disable automatic Gateway resource creation, allowing custom Gateway resources to be managed externally without colliding with the default one.