-
Notifications
You must be signed in to change notification settings - Fork 1
ci: add workflow to lint and test Istio operator and Helm chart #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces GitHub Actions workflows to automate testing and validation for the Istio operator and Helm charts. The workflows will run on pull requests targeting main and release branches when relevant files are modified.
Changes:
- Added a comprehensive workflow to test Helm charts on KOF (Kubernetes on Fire), including unit tests for the Istio operator and deployment verification
- Added PR title validation to enforce conventional commit standards
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/pr_test_helm_chart.yml | Implements automated testing workflow with unit tests and deployment validation for Istio operator and Helm charts |
| .github/workflows/pr_conventional_commit.yaml | Enforces conventional commit format for PR titles |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
132a7d0 to
5121663
Compare
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ fromJSON(steps.pr.outputs.result).merge_commit_sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if we can delete the first step and use this suggestion from actions/checkout#518 (comment)
| ref: ${{ fromJSON(steps.pr.outputs.result).merge_commit_sha }} | |
| ref: "${{ github.event.pull_request.merge_commit_sha }}" |
No description provided.