feat: refactor domain objects deserialization #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpelliccioni
force-pushed
the
feat/domain-obj-deserialization
branch
4 times, most recently
from
9b3d831 to
0b3ce09
Compare
fpelliccioni
force-pushed
the
feat/domain-obj-deserialization
branch
from
0b3ce09 to
e0c8d88
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors domain objects deserialization by centralizing flag conversion logic and updating the consensus API. Key changes include:
- Implementing the verify_flags_to_script_flags function in a new conversions.cpp/ conversions.hpp module.
- Consolidating the consensus API by unifying the verify_script signature and removing conditional branches for script_error_to_verify_result.
- Bumping the Catch2 version in the conanfile.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/consensus/conversions.cpp | Adds verify_flags_to_script_flags with conditional flag conversions. |
| src/consensus/consensus.hpp | Removes conditional definitions and updates version() declaration. |
| include/kth/consensus/export.hpp | Unifies verify_script signature and updates parameter documentation. |
| include/kth/consensus/conversions.hpp | Introduces the header for flag conversion functions. |
| include/kth/consensus.hpp | Updates include directives to incorporate conversions.hpp. |
| conanfile.py | Upgrades Catch2 dependency from 3.6.0 to 3.7.1. |
Files not reviewed (1)
- CMakeLists.txt: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.