You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
Sorry for taking so long to review. I have cherry picked your code for monitor.rs (odd that I did not write it this way in the first place). As for cargo update and cargo clippy I just ran them myself, as it's easier than reviewing, I hope thats ok. I will push all commits and release a new minor version shortly.
As for cargo update and cargo clippy I just ran them myself, as it's easier than reviewing, I hope thats ok.
Sure, no problem. I've been using marswm for the last 18 32 months. Keeping it up-to-date is the least I can do.
I'm really happy with this window manager, it hits the right balance between features and simplicity and it does exactly what I need. I wish I could contribute more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jzbor Could you have a look? I've fixed most of it but,
clippystill warns about:Appreciated.
Thanks!