Add support for the ember-language-server#3
Add support for the ember-language-server#3lougreenwood wants to merge 13 commits intojylamont:mainfrom
ember-language-server#3Conversation
src/lib.rs
Outdated
| ("els-addon-glint", "0.6.4"), | ||
| ("els-a11y-addon", "1.0.4"), | ||
| ("ember-fast-cli", "1.3.1"), | ||
| ("els-intl-addon", "1.0.3"), |
There was a problem hiding this comment.
ELS has builtin els-intl-addon, so, we could skip this one
There was a problem hiding this comment.
Thanks, I was meaning to look into which addons to include by default & whether to version them or always pull the latest ones!
| [ | ||
| (element_node (element_node_start)) | ||
| (block_statement) | ||
| (element_node |
| ; We'll also use this highlighting for named blocks (which start with `:`) | ||
| ((tag_name) @tag | ||
| (#match? @tag "^(:)?[a-z]")) | ||
| (#match? @tag "^:?[%l]")) |
There was a problem hiding this comment.
copied over from the latest tree-sitter-glimmer
|
let me know if you need help 🙏 |
|
Thanks for working on this. Will be happy to test and merge when its ready @lougreenwood. |
src/ember_language_server.rs
Outdated
| // TODO: ONLY INCLUDE THE GLINT ADDON IF WE CAN DETECT THAT THE PROJECT IS A GLINT ONE | ||
| // ... OR SOMETHING LIKE THAT | ||
| ("els-addon-glint", "0.6.4"), | ||
| ("els-a11y-addon", "1.0.4"), |
There was a problem hiding this comment.
els-a11y-addon is embedded to ember-language-server, we could skip it.
|
@lougreenwood are you still working on this? or should someone else take over. Feel like it my be worth it to split this pr into different ones. Formatting |
5 participants
WIP PR adding support for the
ember-language-server.In it's current state it adds linting to
.hbsfiles. I don't get any go to definition, hover support or suggestions in templates yet.TODO: