Export Parser and test#40
Open
jkevlin2 wants to merge 1 commit intojwtk:masterfrom
jkevlin2:issues/39
Open
Conversation
Author
|
I submitted the changes, but I couldn't wait, so I had to fork the repo and
push the changes there.
https://github.com/nodeaholic/jwt-node
Subject: Re: [jwtk/njwt] Export Parser and test (#40)
+1. Would love for this to be built-in functionality instead of having to
manually import source files.
|
eszjay
approved these changes
Mar 1, 2019
eszjay
left a comment
There was a problem hiding this comment.
This looks super useful! I'd love to be able to use the parser to read elements from the token prior to verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to get access to the key id in the header for a key lookup, it would be helpful to have access to the parser.
Addresses issue #39