BREAKING CHANGE: update setIssuedAt method to accept Date or milliseconds instead of seconds#102
Open
shuowu-okta wants to merge 3 commits intojwtk:masterfrom
Open
Conversation
denysoblohin-okta
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
setIssuedAtmethod signature to accept Date or milliseconds as input to be consistent withsetExpirationandsetNotBefore(Resolves JWT expiration and issuedAt properties and setters are inconsistent #93)testfolder from the release package (Resolves Twistlock reported issue with test keys #95 )