Flesh coin dev #17

wstathis · 2020-03-20T22:31:35Z

the meatMarket is open babyyy

… left

jwparsons · 2020-03-20T22:35:00Z

You gotta clarify what the fuck this is

jwparsons · 2020-03-20T22:35:45Z

+420 −11 😏

wstathis · 2020-03-20T22:42:22Z

No changes to base functionality. Added !post, !market, and !market rules

!post <buy/sell/adjust> <price> <amt MC>
    Creates a buy/sell post on the meatMarket with the provided values, or adjusts your current post.
    Users cannot have multiple posts, and there is a xaction fee of %7 for adjustments.
!market
    displays all of the current postings
!market rules
    basically just says what I put under !post above

wstathis · 2020-03-20T22:43:55Z

also how does your CI work, seems like it just always fails npm

jwparsons · 2020-03-20T22:45:28Z

also how does your CI work

It doesn't yet. I think we need to add a test file which exercises certain functionality. You're welcome to take a crack at it.

jwparsons · 2020-03-20T22:46:21Z

No changes to base functionality. Added !post, !market, and !market rules

    Creates a buy/sell post on the meatMarket with the provided values, or adjusts your current post.
    Users cannot have multiple posts, and there is a xaction fee of %7 for adjustments.
!market
    displays all of the current postings
!market rules
    basically just says what I put under !post above```

Does this mean you can only buy and sell with other people?

Dkohanski · 2020-03-20T22:49:31Z

index.js

+            message.author.send('Your posting:\n' + id.padStart(18,'0') + '\tS ' + String(market[1][id].quantity).padStart(10,' ') + '\t@' + String(market[1][id].price).padStart(8,' ') + '\n');
+            return;
+        }
+        response += ', is looking to unload some meat, get it while it\'s hot';


Love this lmao
response += ', is looking to unload some meat, get it while it's hot';

Dkohanski · 2020-03-20T22:52:26Z

index.js

+        // history not sure if we want this in history here, probably in processMarket()....
+        // if (userData.history.length > 9)
+        //     userData.history.pop();
+        // userData.history.unshift('b' + ',' + amount.toFixed(2) + ',' + price.toFixed(2));
+
+        // statistics
+        //volume.bought += amount;


Check if want to remove?

Dkohanski · 2020-03-20T22:52:52Z

index.js

+        // history not sure if we want this in history here, probably in processMarket()....
+        // if (userData.history.length > 9)
+        //     userData.history.pop();
+        // userData.history.unshift('b' + ',' + amount.toFixed(2) + ',' + price.toFixed(2));
+
+        // statistics
+        //volume.bought += amount;


Check if want to remove?

wstathis · 2020-03-21T01:19:22Z

Need to change DMs to users to use name instead of ID or just remove altogether

wstathis · 2020-03-21T15:42:03Z

fix name padding - moot if we make anon

SELLERS-----------+------------QUANTITY+---------PRICE+
Sabrina the Teenage Lich|                 1.8|           1.1|

wstathis · 2020-03-21T15:49:34Z

~~Price matching function currently only adds to volume.bought, needs to write to volume.sold too~~
just adding volume.traded

wstathis · 2020-03-21T17:03:21Z

Need to handle when two posts match 2:1 buyer:seller or vice versa, currently causes crash

TypeError: negPrice.toFixed is not a function
    at C:\Users\NigelThornburry\MeatCoin\index.js:1240:129
    at Array.forEach (<anonymous>)
    at C:\Users\NigelThornburry\MeatCoin\index.js:1190:38
    at Array.forEach (<anonymous>)
    at processMarket (C:\Users\NigelThornburry\MeatCoin\index.js:1187:29)
    at post (C:\Users\NigelThornburry\MeatCoin\index.js:1179:5)
    at Client.<anonymous> (C:\Users\NigelThornburry\MeatCoin\index.js:122:13)
    at Client.emit (events.js:311:20)
    at MessageCreateAction.handle (C:\Users\NigelThornburry\MeatCoin\node_modules\discord.js\src\client\actions\MessageCreate.js:31:14)
    at Object.module.exports [as MESSAGE_CREATE] (C:\Users\NigelThornburry\MeatCoin\node_modules\discord.js\src\client\websocket\handlers\MESSAGE_CREATE.js:4:32)

jwparsons · 2020-03-21T19:47:01Z

.gitignore

+data/token.txt
+#keep price local


Add a space.

jwparsons · 2020-03-21T19:48:57Z

index.js

+    }
+    market[0]=buyerData;
+    market[1]=sellerData;
+


Remove newline.

jwparsons · 2020-03-21T19:49:40Z

index.js

+function printMarket(message) {
+var response = '```glsl\nGET YER FLESH HERE!\n';
+if (Object.keys(market[1]).length > 0) {
+    response += 'SELLERS'.padEnd(18,'-') + '+' + 'QUANTITY'.padStart(20,'-') + '+' + 'PRICE'.padStart(14,'-') + '+\n';
+    Object.keys(market[1]).forEach(function(key) { 
+        response += market[1][key].username.padEnd(18,' ') + '|' + String(market[1][key].quantity).padStart(20,' ') + '|' + String(market[1][key].price).padStart(14,' ') + '|\n';
+    });
+}
+if (Object.keys(market[0]).length > 0) {
+    response += 'BUYERS'.padEnd(18,'-') + '+' + 'QUANTITY'.padStart(20,'-') + '+' + 'PRICE'.padStart(14,'-') + '+\n';
+    Object.keys(market[0]).forEach(function(key) {
+        response += market[0][key].username.padEnd(18,' ') + '|' + String(market[0][key].quantity).padStart(20,' ') + '|' + String(market[0][key].price).padStart(14,' ') + '|\n';
+    });
+}
+response += '```';
+message.channel.send(response);


NO TABS????????????

jwparsons · 2020-03-21T19:50:59Z

index.js

+function post(message, command, price, coinage){
+


Need a space before { and remove the newline.

jwparsons · 2020-03-21T19:51:20Z

index.js

+            return;
+        }
+        //check that the user is not already buying
+        if (id in market[0]){


Space before {

jwparsons · 2020-03-21T19:59:05Z

index.js

+    else if (command == 'adjust'){
+        //adjusting a buy
+        if (id in market[0]){


Space before {

jwparsons · 2020-03-21T20:00:05Z

index.js

+        //adjusting a buy
+        if (id in market[0]){
+            //remvoing post
+            if (amount <= 0.0 || floatPrice <= 0.0){


Make sure there is a space before every {. I'll stop making this comment.

jwparsons · 2020-03-21T20:01:05Z

index.js

+
+    }
+    else{
+        response += ', ' + command + ' is not a valid command. ya dingus!';


jwparsons · 2020-03-21T20:02:39Z

index.js

+    var buyers = market[0];
+    var sellers = market[1];
+    //iterate through buyers
+    if (Object.keys(buyers).length > 0) {
+        Object.keys(buyers).forEach(function(Bkey) {
+            //iterate through sellers
+            if (Object.keys(sellers).length > 0) {
+                Object.keys(sellers).forEach(function(Skey) {
+                    // check if we can make a deal
+                    if(buyers[Bkey].price >= sellers[Skey].price){ //price match
+                        var negPrice = buyers[Bkey].price; //probably won't happen too much, but good to be safe, buyers lose
+                        //Buying > Selling
+                        if(buyers[Bkey].quantity > sellers[Skey].quantity){ 
+                            var buyerData = ledger[Bkey];
+                            var sellerData = ledger[Skey];
+                            //credit both parties as they have already paid
+                            buyerData.meatCoin += parseFloat(sellers[Skey].quantity);
+                            volume.bought += parseFloat(sellers[Skey].quantity);
+                            sellerData.gold += sellers[Skey].quantity * negPrice;
+                            if (buyerData.history.length > 9)
+                                buyerData.history.pop();
+                            buyerData.history.unshift('b' + ',' + parseFloat(sellers[Skey].quantity).toFixed(2) + ',' + negPrice.toFixed(2));
+                            if (sellerData.history.length > 9)
+                                sellerData.history.pop();
+                            sellerData.history.unshift('s' + ',' + parseFloat(sellers[Skey].quantity).toFixed(2) + ',' + negPrice.toFixed(2));
+                            //decrease buyer quantity by amount sold, remove seller posting
+                            buyers[Bkey].quantity -= sellers[Skey].quantity;
+                            delete sellers[Skey];
+                        }
+                        //Selling > Buying
+                        else if (sellers[Skey].quantity > buyers[Bkey].quantity){
+                            var buyerData = ledger[Bkey];
+                            var sellerData = ledger[Skey];
+                            //credit both parties as they have already paid
+                            buyerData.meatCoin += parseFloat(buyers[Bkey].quantity);
+                            volume.bought += parseFloat(buyers[Bkey].quantity);
+                            sellerData.gold += buyers[Bkey].quantity * negPrice;
+                            if (buyerData.history.length > 9)
+                                buyerData.history.pop();
+                            buyerData.history.unshift('b' + ',' + parseFloat(buyers[Bkey].quantity).toFixed(2) + ',' + negPrice.toFixed(2));
+                            if (sellerData.history.length > 9)
+                                sellerData.history.pop();
+                            sellerData.history.unshift('s' + ',' + parseFloat(buyers[Bkey].quantity).toFixed(2) + ',' + negPrice.toFixed(2));
+                            //decrease seller quantity by amount sold, remove buyer posting
+                            sellers[Skey].quantity -= buyers[Bkey].quantity;
+                            delete buyers[Bkey];
+                        }
+                        //equal
+                        else{
+                            var buyerData = ledger[Bkey];
+                            var sellerData = ledger[Skey];
+                            //credit both parties as they have already paid
+                            buyerData.meatCoin += parseFloat(buyers[Bkey].quantity);
+                            volume.bought += parseFloat(buyers[Bkey].quantity);
+                            sellerData.gold += buyers[Bkey].quantity * negPrice;
+                            if (buyerData.history.length > 9)
+                                buyerData.history.pop();
+                            buyerData.history.unshift('b' + ',' + parseFloat(buyers[Bkey].quantity).toFixed(2) + ',' + negPrice.toFixed(2));
+                            if (sellerData.history.length > 9)
+                                sellerData.history.pop();
+                            sellerData.history.unshift('s' + ',' + parseFloat(buyers[Bkey].quantity).toFixed(2) + ',' + negPrice.toFixed(2));
+                            //decrease seller quantity by amount sold, remove buyer posting
+                            delete sellers[Skey];
+                            delete buyers[Bkey];
+                        }
+                    }
+                })
+            }
+        });
+    }
+}
+


Try to space out the code. Put a newline before all the comments (thank you for having comments) and some of the if statements.

jwparsons · 2020-03-21T20:05:38Z

index.js

+    var sellers = market[1];
+    //iterate through buyers
+    if (Object.keys(buyers).length > 0) {
+        Object.keys(buyers).forEach(function(Bkey) {


Are we doing list iterations here? Can we perhaps use a hash map instead? To find matching buy/sells.

wstathis added 5 commits March 19, 2020 15:24

updates to not commit txt files

6f3f926

Added market parsing and printing

225a739

Added full functionality for the meat market, just the actual trading…

8d3b3e7

… left

added transaction functionality, the meat market is open!

4cda571

help text fix

bb8048d

Dkohanski reviewed Mar 20, 2020

View reviewed changes

Dkohanski self-requested a review March 20, 2020 23:03

wstathis requested a review from jwparsons March 20, 2020 23:05

wstathis added the WiP Work in Progress label Mar 21, 2020

jwparsons requested changes Mar 21, 2020

View reviewed changes

update to include volume.traded, removed comments

f94efc3

		data/token.txt
		#keep price local

Flesh coin dev #17

Are you sure you want to change the base?

Flesh coin dev #17

Uh oh!

Conversation

wstathis commented Mar 20, 2020

Uh oh!

jwparsons commented Mar 20, 2020

Uh oh!

jwparsons commented Mar 20, 2020

Uh oh!

wstathis commented Mar 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wstathis commented Mar 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jwparsons commented Mar 20, 2020

Uh oh!

jwparsons commented Mar 20, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wstathis commented Mar 21, 2020

Uh oh!

wstathis commented Mar 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wstathis commented Mar 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wstathis commented Mar 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wstathis commented Mar 20, 2020 •

edited

Loading

wstathis commented Mar 20, 2020 •

edited

Loading

wstathis commented Mar 21, 2020 •

edited

Loading

wstathis commented Mar 21, 2020 •

edited

Loading

wstathis commented Mar 21, 2020 •

edited

Loading