Skip to content

Conversation

@wjk
Copy link

@wjk wjk commented Feb 24, 2013

Here is the pull request you asked for earlier. It contains the following changes:

  • Added the splitterPositions Objective-C property
  • Added the JWSplitViewDelegate protocol
  • Added the JWSplitViewDidResizeNotification
  • Split JWSplitView.h and JWSplitView.m out into a separate framework. I did this because I happen to like embedded frameworks; edit to taste.
  • Updated the README file; you might or might not want to merge this.

@jwilling
Copy link
Owner

Fantastic, thanks for this! One thing. It seems that the constraining methods don't work on split views other than the first one. This might be my implementation's fault, or it could be that a case wasn't covered in this new code, but in any case it does not seem to be functioning correctly.

If you don't have time to look into it, let me know so I can merge this in and debug it a bit myself, otherwise I'll wait to merge until further notice from you.

@wjk
Copy link
Author

wjk commented Feb 26, 2013

I never covered that particular case, as I only used split views with one splitter and two subviews. I'll try to find time to look into this; I would be appreciative if you did as well. Thanks!

@jwilling
Copy link
Owner

jwilling commented Mar 4, 2013

No rush at all. I'm extremely busy at the moment so I can't look at it either until things slow down over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants