Import compiler optimized functions for big performance gain #20
Open
beberlei wants to merge 1 commit intojwadhams:masterfrom
Open
Import compiler optimized functions for big performance gain #20beberlei wants to merge 1 commit intojwadhams:masterfrom
beberlei wants to merge 1 commit intojwadhams:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a case where we used an excessive amount of large formulas in a script, importing these functions made a 100ms+ difference, because the engine could skip calling the internal PHP functions and directly work on opcodes. Being called in the 100.000s, this matters.
Here you can see 200ms being saved in Tideways on that project with the use function imports alone: