Added a function to find a device which starts with a given name #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a function to find a device which starts with a given name. The Xilinx Vivado and SDK creates a device tree file which contains the base address as a part of the name (e.g. "axi_bram_ctrl@6fff0000"). It is not possible to implement a general search for the base adresse of a device with "three byname(const char *name)" when the base address have to be part of the search string.
jviki
requested changes
Apr 9, 2018
Owner
jviki
left a comment
jviki
left a comment
There was a problem hiding this comment.
Thank you for contribution, please note the one simple comment and fix it. I'll approve the pull request then.
dtree.h
Outdated
| * Returns NULL when not found or on error. | ||
| * On error sets error state. | ||
| */ | ||
| struct dtree_dev_t *dtree_startbyname(const char *name); |
Owner
There was a problem hiding this comment.
Please, just rename the function to something like dtree_byname_prefix to stay consistent with original convention bysomething.
Renamed the function and parameter to stay consistent with the original convention: Function: dtree_bysomething Parameter: something
Author
|
Thanks for for the advice. It's definitely a better name for the function. And thank you for the whole lib code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function to find a device which starts with a given name.
The Xilinx Vivado and SDK creates a device tree file which contains the base address as a part of the name (e.g. "axi_bram_ctrl@6fff0000").
It is not possible to implement a general search for the base adresse of a device with "three byname(const char *name)" when the base address have to be part of the search string.