Conversation
Added logic in `PermissionsChecker` to skip checking specific permission strings if the current user running the process is the owner of the folder. Also added a `file_exists` check to prevent `E_WARNING` when paths don't exist, which previously could crash the application. Included a unit test `PermissionsCheckerTest` to verify the new behavior. Co-authored-by: juzaweb <47020363+juzaweb@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Added logic to
PermissionsCheckerso that if the current PHP process owner (getmyuid()) is the same as the folder owner, the permission check automatically passes. Added a check to verifyfile_existsbefore checking owner to prevent warnings. Added tests.PR created automatically by Jules for task 6102135548066478120 started by @juzaweb