Fix 16 using GitHub enterprise #17

lwiechec · 2016-04-01T12:59:37Z

Hi,

I have prepared a first draft of 1.1.2 version that should handle the GitHub Enterprise. It is still not 100% ready (read below), but - could you check if it can deploy with this one to github.com?...

I have still some trouble with publishing to GitHub Enterprise that I work with; I am getting 'connection time out' error, but we are running quite old version of the Enterprise (still need to update it, so it might be it):

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11.590 s
[INFO] Finished at: 2016-04-01T14:55:51+02:00
[INFO] Final Memory: 12M/217M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal de.jutzig:github-release-plugin:1.1.2-SNAPSHOT:release (default-cli) on project nsili-taglib: Failed to upload assets: connect timed out -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal de.jutzig:github-release-plugin:1.1.2-SNAPSHOT:release (default-cli) on project nsili-taglib: Failed to upload assets
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to upload assets
    at de.jutzig.github.release.plugin.UploadMojo.execute(UploadMojo.java:223)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
    ... 20 more
Caused by: java.net.SocketTimeoutException: connect timed out
    at java.net.PlainSocketImpl.socketConnect(Native Method)
    at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
    at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
    at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
    at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
    at java.net.Socket.connect(Socket.java:589)
    at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:668)
    at sun.net.NetworkClient.doConnect(NetworkClient.java:175)
    at sun.net.www.http.HttpClient.openServer(HttpClient.java:432)
    at sun.net.www.http.HttpClient.openServer(HttpClient.java:527)
    at sun.net.www.protocol.https.HttpsClient.<init>(HttpsClient.java:264)
    at sun.net.www.protocol.https.HttpsClient.New(HttpsClient.java:367)
    at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(AbstractDelegateHttpsURLConnection.java:191)
    at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1104)
    at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:998)
    at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:177)
    at sun.net.www.protocol.http.HttpURLConnection.getOutputStream0(HttpURLConnection.java:1282)
    at sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:1257)
    at sun.net.www.protocol.https.HttpsURLConnectionImpl.getOutputStream(HttpsURLConnectionImpl.java:250)
    at org.kohsuke.github.Requester.buildRequest(Requester.java:322)
    at org.kohsuke.github.Requester._to(Requester.java:233)
    at org.kohsuke.github.Requester.to(Requester.java:203)
    at org.kohsuke.github.GHRelease.uploadAsset(GHRelease.java:132)
    at de.jutzig.github.release.plugin.UploadMojo.uploadAsset(UploadMojo.java:249)
    at de.jutzig.github.release.plugin.UploadMojo.execute(UploadMojo.java:210)
    ... 22 more

for running the plugin tests

in Github Enterprise installations the values are of course different from the 'standard' github.com's. The default values are from github.com, though. This means that 'computeRepositoryId()' cannot be made static, as it takes the values of Github (Enterprise)'s hostname to contruct the regexp. refs jutzig#16

testing directory containing POMs that, using github-release-plugin, will be used in tests

this defines plugin's prefix etc

fixing issue with regexp

adding test POM for (imaginary) GitHub Enterprise server

lwiechec · 2016-04-02T12:17:56Z

Hi, I think I have figured out why it is not working on my GitHub Enterprise; check GHRelease, line 130; it is using hard-coded path to the 'regular' github.com, instead of Github Enterprise. And we are using it in UploadMojo.
I have already submitter a bug report at gihub-api repo...

jutzig · 2016-04-02T12:39:03Z

Ah, that is to bad.
If there is a new release that fixes the bug I will gladly merge your pull
request and release a new version though.

Best regards,
Johannes
Am 02.04.2016 14:17 schrieb "Lukasz Wiechec" notifications@github.com:

Hi, I think I have figured out why it is not working on my GitHub
Enterprise; check GHRelease, line 130
https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GHRelease.java#L130;
it is using hard-coded path to the 'regular' github.com, instead of
Github Enterprise. And we are using it in UploadMojo
https://github.com/lwiechec/github-release-plugin/blob/fix-16-using-Github-Enterprise/src/main/java/de/jutzig/github/release/plugin/UploadMojo.java#L249
.
I have already submitter a bug report
hub4j/github-api#266 at gihub-api repo...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#17 (comment)

I have opened issue there and presented the pull request to the github-api team; this is using it. refs jutzig#16

refs jutzig#16

lwiechec added 21 commits April 1, 2016 11:06

adding maven plugin test harness

524dbec

for running the plugin tests

updating to latest Maven core etc

afed133

attempting to create a test

e421922

initial

15c75de

testing directory containing POMs that, using github-release-plugin, will be used in tests

adding plexus component for the plugin

9641f57

this defines plugin's prefix etc

adding Maven Plugin plugin call

98a70b5

updating repository pattern

362a8fe

fixing issue with regexp

replacing with new-style annotations

3c42da2

fixing indentation

2fffbec

adding annotations dependency

bc99daa

renaming dir with test pom for github.com

30b40a6

initial

784589c

adding test POM for (imaginary) GitHub Enterprise server

adding missing @parameter

d444891

extending tests for GitHub Enterprise scenario

cb9afc7

removing as uneeded

43ee01a

upgrading to latest version of GitHub API

8afab3c

fixing typo

04be495

github.com name put in the var

b2da0fb

api changed, it getId() returns int

e91a1fc

updating the docs

332a0ab

lwiechec added 4 commits April 4, 2016 10:00

adapting to github-api 1.75-SNAPSHOT

9d96ad3

I have opened issue there and presented the pull request to the github-api team; this is using it. refs jutzig#16

using pre-release of 1.75-SNAPSHOT

a410860

refs jutzig#16

updating docs

f79db30

refs jutzig#16

making sure upload prefix url does not end with '/'

e80b9f1

refs jutzig#16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 16 using GitHub enterprise #17

Fix 16 using GitHub enterprise #17

Uh oh!

lwiechec commented Apr 1, 2016

Uh oh!

lwiechec commented Apr 2, 2016

Uh oh!

jutzig commented Apr 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix 16 using GitHub enterprise #17

Are you sure you want to change the base?

Fix 16 using GitHub enterprise #17

Uh oh!

Conversation

lwiechec commented Apr 1, 2016

Uh oh!

lwiechec commented Apr 2, 2016

Uh oh!

jutzig commented Apr 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants