Conversation
Convert it to a regular array in the needed places
Generating SQL with a clause or applying a clause to a collection should result in the same outcome. There is a difference in behavior for empty `Multiple` clause for condition clauses and ordering clauses. - The implementation of empty `Multiple` clauses was wrong for SQL, it should not match anything. This now matches the PHP implementation. - `Multiple` ordering clauses were not properly applied to a query, the logic for condition was used, which is not right
Previously the presenters would only use the clauses to filter and/or order the found entities after the query was run. This might be wasteful if the clause is used to only select a small subset of the query result. Using the clause in the query makes the query less wasteful, this behavior is skipped if the entity pool has a request for different clauses for the same entities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make clauses more consistent in SQL and PHP form
Generating SQL with a clause or applying a clause to a collection should
result in the same outcome. There is a difference in behavior for empty
Multipleclause for condition clauses and ordering clauses.Multipleclauses was wrong for SQL, itshould not match anything. This now matches the PHP implementation.
Multipleordering clauses were not properly applied to a query, thelogic for condition was used, which is not right
Include clauses in presenter queries
Previously the presenters would only use the clauses to filter and/or
order the found entities after the query was run. This might be wasteful
if the clause is used to only select a small subset of the query result.
Using the clause in the query makes the query less wasteful, this
behavior is skipped if the entity pool has a request for different
clauses for the same entities.