Conversation
vaibhavjuspay
left a comment
vaibhavjuspay
left a comment
There was a problem hiding this comment.
@AviGawande I just reviewed the PR, added some comments over there. Kindly check and address the issues.
locale/hyperswitch-checkout.pot
Outdated
| @@ -0,0 +1,268 @@ | |||
| # Copyright (C) 2024 Hyperswitch | |||
There was a problem hiding this comment.
why we are having 2 different pot files, generally it is preferred to have a single pot file across plugin to ensure consistency and simplicity.
There was a problem hiding this comment.
yes will fix that and commit changes.
| if (!empty($missing)) { | ||
| echo "Found translation functions missing 'hyperswitch' text domain:\n\n"; | ||
| foreach ($missing as $item) { | ||
| echo "File: {$item['file']}\n"; |
There was a problem hiding this comment.
Won't it be better to log the results to a file, or at least printing the output in a more structured format (JSON, CSV, etc.) to make it easier to review.
There was a problem hiding this comment.
could you plz explain me what change to implement.
|
Hey @AviGawande Any updates? |
|
yes @gorakhnathy7 working on it |
|
@AviGawande why are we still keeping .po~ files ? possible to remove these and keeping only .po ones ? |
|
@vaibhavjuspay done, Pls Review. |
3 participants
This PR fixes #6170 and added the locale support to WooCommerce Plugin.