Skip to content

fix: replace hardcoded 'Invalid input' with localized strings #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArushKapoorJuspay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace hardcoded 'Invalid input' with localized strings #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Components/ErrorComponent.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ open RecoilAtoms

@react.component
let make = (~errorStr=None, ~cardError="", ~expiryError="", ~cvcError="") => {
let {themeObj, config} = Recoil.useRecoilValueFromAtom(configAtom)
let {themeObj, config, localeString} = Recoil.useRecoilValueFromAtom(configAtom)
let {innerLayout} = config.appearance

let errorTextStyle: JsxDOM.style = {
Expand All @@ -29,7 +29,9 @@ let make = (~errorStr=None, ~cardError="", ~expiryError="", ~cvcError="") => {
</RenderIf>
| Compressed =>
<RenderIf condition=isCompressedErrorShown>
<div className="Error pt-1" style=errorTextStyle> {React.string("Invalid input")} </div>
<div className="Error pt-1" style=errorTextStyle>
{React.string(localeString.enterValidDetailsText)}
</div>
</RenderIf>
}
}
2 changes: 1 addition & 1 deletion src/Payments/CardPayment.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ let make = (
alignSelf: "start",
textAlign: "left",
}>
{React.string("Invalid input")}
{React.string(localeString.enterValidDetailsText)}
</div>
</RenderIf>
</RenderIf>
Expand Down
Loading