-
Notifications
You must be signed in to change notification settings - Fork 119
feat: pix automatico #1435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aritro2002
wants to merge
7
commits into
main
Choose a base branch
from
pix-automatico
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+649
−52
Open
feat: pix automatico #1435
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5efa391
feat: pix automatio
aritro2002 f85da1a
refactor: apply suggested changes
aritro2002 2f1689e
refactor: apply suggested changes
aritro2002 9d91aa7
refactor: apply suggested changes
aritro2002 63725b4
Merge branch 'main' of https://github.com/juspay/hyperswitch-web into…
aritro2002 8807fe1
refactor: apply suggested changes
aritro2002 0bfbff6
refactor: apply suggested changes
aritro2002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,42 @@ | ||
| type loaderPaymentMethod = | ||
| | PixAutomaticoPush | ||
| | Other | ||
|
|
||
| type loaderTextConfig = { | ||
| title: string, | ||
| subtitle: string, | ||
| } | ||
|
|
||
| let parsePaymentMethod = methodString => { | ||
| switch methodString { | ||
| | "pix_automatico_push" => PixAutomaticoPush | ||
| | _ => Other | ||
| } | ||
| } | ||
|
|
||
| let getLoaderTextConfig = ( | ||
| paymentMethod: loaderPaymentMethod, | ||
| ~localeString: LocaleStringTypes.localeStrings, | ||
| ) => { | ||
| switch paymentMethod { | ||
| | PixAutomaticoPush => { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. User-facing loader text is hardcoded in English, violating the codebase's i18n pattern used elsewhere (see Suggested Fix: type localeStrings = {
...
loaderProcessingTitle: string,
loaderProcessingSubtitle: string,
loaderPixPushTitle: string,
loaderPixPushSubtitle: string,
}Then pass posted by PR reviewer bot |
||
| title: localeString.loaderPaymentConfirmBankingAppTitle, | ||
| subtitle: localeString.loaderPaymentConfirmBankingAppSubtitle, | ||
| } | ||
| | Other => { | ||
| title: localeString.loaderPaymentProcessingTitle, | ||
| subtitle: localeString.loaderPaymentProcessingSubtitle, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @react.component | ||
| let make = (~branding="auto", ~showText=true) => { | ||
| let make = (~branding="auto", ~showText=true, ~paymentMethod="") => { | ||
| let arr = ["hyperswitch-triangle", "hyperswitch-square", "hyperswitch-circle"] | ||
| let {localeString} = Recoil.useRecoilValueFromAtom(RecoilAtoms.configAtom) | ||
|
|
||
| let parsedPaymentMethod = parsePaymentMethod(paymentMethod) | ||
| let textConfig = getLoaderTextConfig(parsedPaymentMethod, ~localeString) | ||
|
|
||
| <div className="flex flex-col gap-10 justify-center items-center"> | ||
| <div className="flex flex-row gap-10"> | ||
|
|
@@ -33,12 +69,10 @@ let make = (~branding="auto", ~showText=true) => { | |
| <RenderIf condition={showText}> | ||
| <div className="flex flex-col gap-5"> | ||
| <div className="font-semibold text-sm text-gray-200 self-center "> | ||
| {React.string("We are processing your payment...")} | ||
| {React.string(textConfig.title)} | ||
| </div> | ||
| <div className="font-medium text-xs text-gray-400 self-center text-center w-3/4 "> | ||
| {React.string( | ||
| "You have been redirected to new tab to complete your payments. Status will be updated automatically", | ||
| )} | ||
| {React.string(textConfig.subtitle)} | ||
| </div> | ||
| </div> | ||
| </RenderIf> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loader checks for
"pix_automatico_push", butPaymentMethodsRecord.resandDynamicFieldsUtils.resuse"pix_automatico_push_transfer". The loader will never match and always show generic "Other" text for Pix Automatico Push payments.Suggested Fix:
posted by PR reviewer bot