Skip to content

fix: chinese locale#1400

Open
Shivam25092001 wants to merge 1 commit intofix-shared-code-localefrom
fix-chinese-locale
Open

fix: chinese locale#1400
Shivam25092001 wants to merge 1 commit intofix-shared-code-localefrom
fix-chinese-locale

Conversation

@Shivam25092001
Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added support for Chinese locales while migrating locales to shared-code.

How did you test it?

  • Used proxy for testing since new locale was added and was yet to be published on s3.
// webpack.dev.js

  static: [
    {
      directory: path.join(__dirname, "dist"),
    },
    {
      directory: path.join(__dirname, "shared-code/assets/v2/jsons/locales"),
      publicPath: "/assets/v2/jsons/locales",
    },
  ],
image

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com bot commented Feb 26, 2026

Review changes with  SemanticDiff

@github-actions
Copy link
Copy Markdown
Contributor

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

  • Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
  • Or link it manually using the "Linked issues" panel in the PR sidebar.

Tip: You can link multiple issues.
🚫 Note: If only one issue is linked, it must be open for this check to pass.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label Feb 26, 2026
@Shivam25092001 Shivam25092001 changed the title Fix chinese locale fix: chinese locale Feb 26, 2026
@github-actions github-actions bot removed the S-conventions-not-followed Some Github conventions not followed label Feb 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

  • Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
  • Or link it manually using the "Linked issues" panel in the PR sidebar.

Tip: You can link multiple issues.
🚫 Note: If only one issue is linked, it must be open for this check to pass.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

@Shivam25092001 Shivam25092001 changed the base branch from main to fix-shared-code-locale February 26, 2026 08:56
@github-actions
Copy link
Copy Markdown
Contributor

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

  • Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
  • Or link it manually using the "Linked issues" panel in the PR sidebar.

Tip: You can link multiple issues.
🚫 Note: If only one issue is linked, it must be open for this check to pass.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

@Shivam25092001 Shivam25092001 added the DO NOT MERGE Use this label if you want your PR to restrict from merging label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Use this label if you want your PR to restrict from merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant