Skip to content

refactor: move probes and resources to values.yaml #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmatviichuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: move probes and resources to values.yaml #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/incubator/hyperswitch-card-vault/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.5
version: 0.1.6

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
22 changes: 21 additions & 1 deletion charts/incubator/hyperswitch-card-vault/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# hyperswitch-card-vault

![Version: 0.1.5](https://img.shields.io/badge/Version-0.1.5-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.16.0](https://img.shields.io/badge/AppVersion-1.16.0-informational?style=flat-square)
![Version: 0.1.6](https://img.shields.io/badge/Version-0.1.6-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.16.0](https://img.shields.io/badge/AppVersion-1.16.0-informational?style=flat-square)

"application"
A Helm chart for creating Hyperswitch Card Vault
Expand Down Expand Up @@ -175,8 +175,28 @@ external:
| server.host | string | `"0.0.0.0"` | |
| server.image | string | `"juspaydotin/hyperswitch-card-vault:v0.6.5-dev"` | |
| server.imageRegistry | string | `"docker.juspay.io"` | |
| server.livenessProbe.failureThreshold | int | `3` | |
| server.livenessProbe.httpGet.path | string | `"/health"` | |
| server.livenessProbe.httpGet.port | int | `8080` | |
| server.livenessProbe.httpGet.scheme | string | `"HTTP"` | |
| server.livenessProbe.initialDelaySeconds | int | `5` | |
| server.livenessProbe.periodSeconds | int | `30` | |
| server.livenessProbe.successThreshold | int | `1` | |
| server.livenessProbe.timeoutSeconds | int | `1` | |
| server.pod.annotations | object | `{}` | |
| server.port | string | `"8080"` | |
| server.readinessProbe.failureThreshold | int | `3` | |
| server.readinessProbe.httpGet.path | string | `"/health"` | |
| server.readinessProbe.httpGet.port | int | `8080` | |
| server.readinessProbe.httpGet.scheme | string | `"HTTP"` | |
| server.readinessProbe.initialDelaySeconds | int | `5` | |
| server.readinessProbe.periodSeconds | int | `50` | |
| server.readinessProbe.successThreshold | int | `1` | |
| server.readinessProbe.timeoutSeconds | int | `1` | |
| server.resources.limits.cpu | string | `"500m"` | |
| server.resources.limits.memory | string | `"700Mi"` | |
| server.resources.requests.cpu | string | `"100m"` | |
| server.resources.requests.memory | string | `"200Mi"` | |
| server.vault.url | string | `"http://127.0.0.1:8200"` | |
| server.version | string | `"v0.6.5"` | |
| tenant_secrets.public.master_key | string | `"8283d68fdbd89a78aef9bed8285ed1cd9310012f660eefbad865f20a3f3dd9498f06147da6a7d9b84677cafca95024990b3d2296fbafc55e10dd76df"` | |
Expand Down
30 changes: 9 additions & 21 deletions charts/incubator/hyperswitch-card-vault/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,35 +162,23 @@ spec:
- /bin/bash
- -c
- pkill -15 node
{{- with .Values.server.livenessProbe }}
livenessProbe:
failureThreshold: 3
httpGet:
path: /health
port: 8080
scheme: HTTP
initialDelaySeconds: 5
periodSeconds: 30
successThreshold: 1
timeoutSeconds: 1
{{- toYaml . | nindent 12 }}
{{- end }}
name: tartarus
ports:
- containerPort: 8080
name: http
protocol: TCP
{{- with .Values.server.readinessProbe }}
readinessProbe:
failureThreshold: 3
httpGet:
path: /health
port: 8080
scheme: HTTP
initialDelaySeconds: 5
periodSeconds: 50
successThreshold: 1
timeoutSeconds: 1
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.server.resources }}
resources:
requests:
cpu: 100m
memory: 200Mi
{{- toYaml . | nindent 12 }}
{{- end }}

securityContext:
privileged: false
Expand Down
30 changes: 30 additions & 0 deletions charts/incubator/hyperswitch-card-vault/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,36 @@ server:
vault:
url: "http://127.0.0.1:8200"

livenessProbe:
failureThreshold: 3
httpGet:
path: /health
port: 8080
scheme: HTTP
initialDelaySeconds: 5
periodSeconds: 30
successThreshold: 1
timeoutSeconds: 1

readinessProbe:
failureThreshold: 3
httpGet:
path: /health
port: 8080
scheme: HTTP
initialDelaySeconds: 5
periodSeconds: 50
successThreshold: 1
timeoutSeconds: 1

resources:
requests:
cpu: 100m
memory: 200Mi
limits:
cpu: 500m
memory: 700Mi

# Secrets configuration
secrets:
# Core secrets
Expand Down