feat: add postStart hook for vault keys configuration#253
Open
dmatviichuk wants to merge 1 commit intojuspay:mainfrom
Open
feat: add postStart hook for vault keys configuration#253dmatviichuk wants to merge 1 commit intojuspay:mainfrom
dmatviichuk wants to merge 1 commit intojuspay:mainfrom
Conversation
- Move vault keys to top-level vaultKeys section - Extract postStart config to vaultKeysPostStart - Add validation to prevent Job and postStart from being enabled simultaneously - Update deployment to support postStart lifecycle hook
dmatviichuk
force-pushed
the
feature/vault-keys-poststart-hook
branch
from
e2dafc8 to
e309446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change:
Some users run on AWS Spot Instances, where the card vault pod can restart frequently. Each restart requires manually unlocking the vault, which is disruptive. The existing Job-based approach only runs on Helm hooks (post-install, post-upgrade), so it doesn't handle pod restarts. This leaves the vault locked after restarts.
This change adds a postStart lifecycle hook that runs automatically when the container starts, ensuring the vault keys are configured after each restart without manual intervention. This is especially useful for Spot Instances and other scenarios where pods restart frequently.