chore: add sidebar and route level permissions for recon engine#4713
Open
Muditbhatia12 wants to merge 6 commits intomainfrom
Open
chore: add sidebar and route level permissions for recon engine#4713Muditbhatia12 wants to merge 6 commits intomainfrom
Muditbhatia12 wants to merge 6 commits intomainfrom
Conversation
|
Review changes with |
Muditbhatia12
changed the title
github-actions
bot
added
S-conventions-not-followed
Muditbhatia12
changed the title
Contributor
Author
|
@control_center_review_bot pls review this pr |
Collaborator
hs-control-center-bot
left a comment
hs-control-center-bot
left a comment
There was a problem hiding this comment.
Verdict: 🔄 Request Changes
The authorization implementation introduces inconsistencies between route-level group access checks and sidebar resource-level permissions. Specifically, Transformation and Transformed-Entries routes check ReconSourcesView while their sidebar links use distinct resource access types, which could lead to confusing UX where users see links they cannot access. Additionally, the Overview route lacks authorization gating unlike all other routes.
susrithasabbini
approved these changes
Apr 16, 2026
kanikabansal08
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
recon data enginner (no exceptions view)
recon Merchant operator (no reocn sources view)
Motivation and Context
How did you test it?
Where to test it?
Checklist
npm run re:build