Skip to content

chore: add recon permission group mappings#4712

Merged
prajwalnl merged 2 commits intomainfrom
recon-roles-mapping
Apr 15, 2026
Merged

chore: add recon permission group mappings#4712
prajwalnl merged 2 commits intomainfrom
recon-roles-mapping

Conversation

@Muditbhatia12
Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This pr adds the mappings for recon engine related permission group mappings

Motivation and Context

How did you test it?

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Muditbhatia12 Muditbhatia12 self-assigned this Apr 14, 2026
@Muditbhatia12 Muditbhatia12 requested a review from a team as a code owner April 14, 2026 18:11
@semanticdiff-com
Copy link
Copy Markdown

Review changes with  SemanticDiff

@kanikabansal08
Copy link
Copy Markdown
Collaborator

@control_center_review_bot please review this pr?

Copy link
Copy Markdown
Collaborator

@hs-control-center-bot hs-control-center-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: 🔄 Request Changes

⚠️ 1 warning · 💡 0 suggestions · 🔍 0 nitpicks

The new recon permission variants were added to the type definition and mapper functions, but the groupAccessJsonType record and related functions weren't updated to expose these permissions through the typed permission JSON structure. This creates a gap where the backend can return recon permissions but UI components can't access them via the standard userPermissionAtom interface.

@hs-control-center-bot
Copy link
Copy Markdown
Collaborator

⚠️ Blast Radius Issue — Missing groupAccessJsonType Extension

File: src/screens/UserManagement/UserRevamp/UserManagementTypes.res

The groupAccessJsonType record type wasn't extended with fields for the 8 new recon permissions. This means when getGroupAccessJson converts the group array to a typed JSON structure, the recon permissions are lost. Similarly, GroupACLMapper.defaultValueForGroupAccessJson lacks corresponding NoAccess defaults for these new fields.

Extend groupAccessJsonType with recon fields:

type groupAccessJsonType = {
  // ... existing fields ...
  themeView: authorization,
  themeManage: authorization,
  reconSourcesView: authorization,
  reconSourcesManage: authorization,
  reconTransactionsView: authorization,
  reconTransactionsManage: authorization,
  reconRulesView: authorization,
  reconRulesManage: authorization,
  reconExceptionsView: authorization,
  reconExceptionsManage: authorization,
}

Then update defaultValueForGroupAccessJson and getGroupAccessJson in GroupACLMapper.res to handle these new fields.

@Muditbhatia12
Copy link
Copy Markdown
Contributor Author

@control_center_review_bot review this pr

@Muditbhatia12
Copy link
Copy Markdown
Contributor Author

@control-center-review_bot pls review this pr again?

@kanikabansal08
Copy link
Copy Markdown
Collaborator

@control_center_review_bot pls review this pr

Copy link
Copy Markdown
Collaborator

@hs-control-center-bot hs-control-center-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

🚨 0 critical · ⚠️ 0 warning · 💡 0 suggestion · 🔍 0 nitpick

Clean additive change extending ACL mappings for recon engine permissions. Follows existing patterns consistently.

@prajwalnl prajwalnl linked an issue Apr 15, 2026 that may be closed by this pull request
@prajwalnl prajwalnl added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 66733ef Apr 15, 2026
14 of 15 checks passed
@prajwalnl prajwalnl deleted the recon-roles-mapping branch April 15, 2026 12:28
@github-actions github-actions bot added the Closed Applied to issues or pull requests that have been successfully resolved or completed label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Closed Applied to issues or pull requests that have been successfully resolved or completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add recon permission group mappings

5 participants