chore: add recon permission group mappings#4712
Conversation
|
@control_center_review_bot please review this pr? |
hs-control-center-bot
left a comment
There was a problem hiding this comment.
Verdict: 🔄 Request Changes
The new recon permission variants were added to the type definition and mapper functions, but the groupAccessJsonType record and related functions weren't updated to expose these permissions through the typed permission JSON structure. This creates a gap where the backend can return recon permissions but UI components can't access them via the standard userPermissionAtom interface.
|
File: The Extend type groupAccessJsonType = {
// ... existing fields ...
themeView: authorization,
themeManage: authorization,
reconSourcesView: authorization,
reconSourcesManage: authorization,
reconTransactionsView: authorization,
reconTransactionsManage: authorization,
reconRulesView: authorization,
reconRulesManage: authorization,
reconExceptionsView: authorization,
reconExceptionsManage: authorization,
}Then update |
|
@control_center_review_bot review this pr |
|
@control-center-review_bot pls review this pr again? |
|
@control_center_review_bot pls review this pr |
hs-control-center-bot
left a comment
There was a problem hiding this comment.
✅ Approve
🚨 0 critical ·
Clean additive change extending ACL mappings for recon engine permissions. Follows existing patterns consistently.
Type of Change
Description
This pr adds the mappings for recon engine related permission group mappings
Motivation and Context
How did you test it?
Where to test it?
Checklist
npm run re:build