feat: migrate RadioIcon to Blend Design System#4640
feat: migrate RadioIcon to Blend Design System#4640kanikabansal08 wants to merge 3 commits intoblend-checkbox-migratefrom
Conversation
YesNoRadioInput has zero call sites in the codebase — dead code removed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@product-manager what do you think |
Analysis: Migrate RadioIcon to Blend Design System (#4640)This is a clean, well-scoped incremental step in the Blend Design System migration chain ( What's done well
Concerns1. Hardcoded fill color in the adapter ( The default 2.
3. Issue #4639 describes a different scope than what shipped The issue says 4. Missing unit tests The checklist shows "I added unit tests" is unchecked. For an adapter that maps prop types between two component APIs (especially the Questions
Next steps
Overall this is a low-risk, well-executed migration step. Ship it once the minor items above are addressed. |
Closes #4639
Type of Change
Description
Migrates
RadioIcon(custom SVG radio indicator) to the Blend Design System. CreatesRadioBinding.res(BlendRadio+RadioGroupbinding) andRadioIconAdapter.res(feature-flagged adapter). All 7<RadioIconcall sites updated to<RadioIconAdapter;RadioIcon.resuntouched.YesNoRadioInput.reshas been removed — it had zero call sites in the codebase and was dead code.Motivation and Context
Continuation of the incremental Blend migration chain (
blend-filters-migrate→blend-checkbox-migrate→ this PR). UnlikeCheckBoxIcon, Blend'sRadiois a native HTML input that does not stop click propagation — parentdiv onClickhandlers fire naturally, so no call-site restructuring was required for the parent-div pattern.How did you test it?
Tested manually with
devBlendEnabled: trueinconfig.toml.UI screens to verify:
Where to test it?
Checklist
npm run re:build